Problem/Motivation

Make Pet entity translatable.

Proposed resolution

Add translatable TRUE in the entity definition.
Add langcode as entity key.
Set translatable to TRUE for the fields that should be translatable.

CommentFileSizeAuthor
#12 make_pet_translatable-2747525-12.patch4.14 KBadinac
#11 make_pet_translatable-2747525-11.patch3.18 KBadinac
#4 0001-Translatable-PETs.patch3.5 KBayalon
#3 make_pet_translatable-2747525-3.patch2.94 KBbogdan.racz
#2 make_pet_translatable-2747525-2.patch2.95 KBbogdan.racz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rbmboogie created an issue. See original summary.

bogdan.racz’s picture

bogdan.racz CreditAttribution: bogdan.racz at Dream Production commented
Assigned: bogdan.racz » Unassigned
Status: Active » Needs review
FileSize
make_pet_translatable-2747525-2.patch2.95 KB

Attached a patch.
Please review.

bogdan.racz’s picture

bogdan.racz CreditAttribution: bogdan.racz at Dream Production commented
FileSize
make_pet_translatable-2747525-3.patch2.94 KB

Forgot to leave the add form in the annotation.
Attached a complete patch.

ayalon’s picture

ayalon CreditAttribution: ayalon at Liip commented
FileSize
0001-Translatable-PETs.patch3.5 KB

Here is my own attempt to make PETs translatable.

After applying the patch you need to run "drush entup". Then you can go to "/admin/config/regional/content-language" and enable "Translation" for the Pet Entity.

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
CreditAttribution: andreasderijcke at Calibrate commented

Tried both patches, both work, 0001-Translatable-PETs.patch seems a bit more concise although patch file itself needs a clean.

However, "drush entup" won't run if pet entities are already present. Update hook needs to added.

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
CreditAttribution: andreasderijcke at Calibrate commented

0001-Translatable-PETs.patch throws errors on uninstall of the module, while make_pet_translatable-2747525-3.patch does not.

andreasderijcke’s picture

andreasderijcke
Location Antwerpen / Gent
CreditAttribution: andreasderijcke at Calibrate commented
Status: Needs review » Needs work

  • Sharique committed 262be4b on 8.x-1.x authored by rbmboogie 
    Issue #2747525 by rbmboogie, ayalon: Make Pet translatable
Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

adinac’s picture

adinac CreditAttribution: adinac as a volunteer commented
FileSize
make_pet_translatable-2747525-11.patch3.18 KB

Although the entity type is translated, the translation is not used in pet_send_mail(). I also added the possibility to pass the language to pet_send_mail().

adinac’s picture

adinac CreditAttribution: adinac as a volunteer commented
FileSize
make_pet_translatable-2747525-12.patch4.14 KB

Other improvements, like sending the language as option to the token replacement callback.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented

Please create a new ticket as this closed long back.

camilo.escobar’s picture

camilo.escobar CreditAttribution: camilo.escobar at Urban Insight commented

The point that @adinac made is important: it is not enough to make the PET entity translatable. All the code involved in sending the emails must be adapted to be able to receive a language parameter, otherwise, just making the entity translatable is useless.
A new issue was created: https://www.drupal.org/project/pet/issues/3366542