In Generalize Builder and Renderer classes and methods we decided to create an 8.x-2.x branch. In this issue, we will add an upgrade path from 1.x to 2.x and add the necessary tests.

CommentFileSizeAuthor
#9 interdiff.txt883 bytesbenjy
#9 2747133-8.patch178.78 KBbenjy
#6 2747133-6.patch178.74 KBbenjy
#5 review-do-not-test.patch3.51 KBbenjy
#4 2747133-3.patch1.41 MBbenjy
#3 2747133-3.patch1.41 MBbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jordanpagewhite created an issue. See original summary.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Parent issue: » #2735561: [META] Introduce new formats
benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Active » Needs review
FileSize
2747133-3.patch1.41 MB

First pass at making this work.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2747133-3.patch1.41 MB
benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
review-do-not-test.patch3.51 KB

This should make it easier to review without the dump.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2747133-6.patch178.74 KB

Smaller dump when compressed.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Title: Add and tests for an upgrade path from 1.x to 2.x » Add upgrade path from 1.x to 2.x
benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
FileSize
2747133-8.patch178.78 KB
interdiff.txt883 bytes
Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Looks good.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented

Hey guys. Sorry I missed your DM. I've never really been DM'd on d.o. before. I didn't realize it sends to email. I'll have to set up an IFTTT recipe for that.

drush updb failed for me

The "print_engine" entity type does not exist.

I am not sure if I am doing something wrong or if this is an actual issue. I apologize for my lack of experience. I have never tested an upgrade path before. Thanks for helping me get this experience!

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

You can test this via:

  1. Install Drupal 8
  2. Enable Entity Print 8.x-1.x
  3. Change a couple of settings around
  4. Switch to Entity Print 8.x-2.x
  5. Run drush updb or visit /update.php to upgrade
  6. Ensure that your config came across as expected, no errors were shown in the output upgrade etc.
jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented

That's what I thought. I think I think I forgot to rebase my branch or something last time. It applies cleanly now! Thanks.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented

applies cleanly or upgrades cleanly?

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented

Sorry. That was unclear. It upgrades cleanly.

benjy’s picture

benjy CreditAttribution: benjy at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

  • benjy committed 4a1f536 on 8.x-2.x 
    Issue #2747133 by benjy, jordanpagewhite, Sam152: Add upgrade path from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.