Hi,

I don't really see the point of having two modules: one to manage Adsense code and one to inject it inside your content. Why wouldn't the two projects merge?

Unless Adsense injector becomes AdInjector and ads compatibility with other type of ads.

Regards.

Comments

kbahey’s picture

kbahey commented
Category: feature » task
Status: Active » Postponed (maintainer needs more info)

It was the decision of the adsense injector author to do so.

With the new refactoring for Drupal 6, which is more modular, it makes sense to merge them, but it is up to the author of adsense injector to decide whether he wants to go that route or not.

alexanderpas’s picture

alexanderpas commented

If not merged, i would at least prefer "awareness" of the other module (for both modules)... meaning, if both modules are enabled, you get more options ;)

mcurry’s picture

mcurry commented

(Adsense Injector module author speaking)

I'm support providing the Adsense injection functionality in this module; the Adsense injector will probably live on regardless (even if under a new name) because I plan on expanding its abilities. For example, it's already quite useful completely aside from its ability to inject Adsense module content into a node or teaser.

In any case, I'll let the Adsense module team decide how to proceed. I wish to preserve the existing Adsense injector module so I would ask that the Drupal-hosted project not be removed or otherwise disabled.

neural’s picture

neural commented

The Injector module should definitely remain as a general purpose inline injector of banners, pictures or whatever one wants.

jcnventura’s picture

jcnventura
Primary language English
commented

(Guy who re-factored the new D6 adsense module speaking)

Sorry to join the party late.. It seems that regardless, the Adsense injector will remain independent. What exactly did you mean with I'm support providing the Adsense injection functionality in this module.

If that's so can we close this issue with a "won't fix"?

João

kbahey’s picture

kbahey commented

@inactivist

It is your choice.

As long as it is independent, we do not want to duplicate the functionality inside the adsense module itself.

If you want to merge it, then submit patches vs. 6.x-1.x-dev to include it as a separate module with the new API.

alexanderpas’s picture

alexanderpas commented

duplicate functionality is not desired, however, awareness of the other module, and being able to use the two module together (without any problems) and with combined functionality is very much desired.

Also, this keeps the option open to make AsenseInjector into AdInjector, and still keep combined functionalities!

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Well, since the merge will never happen, I believe that the only thing remaining is for that module's author/maintainer to make sure that he follows the adsense module interface/API.

João