In mailchimp_campaign.routing.yml, the _permission in each requirements section is set to 'administer mailchimp' instead of the expected 'administer mailchimp campaigns'. This prevents administrators from allowing users to send campaigns without having to give them access to settings as well.

CommentFileSizeAuthor
#14 mailchimp-campaigns-routing-permissions-2746685-14.patch3.04 KBasrob
#2 mailchimp_campaign_permissions.patch2.85 KBChrisGrewe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ChrisGrewe created an issue. See original summary.

ChrisGrewe’s picture

ChrisGrewe CreditAttribution: ChrisGrewe commented
FileSize
mailchimp_campaign_permissions.patch2.85 KB

This patch should do the trick. Changes the permissions to the administer mailchimp campaigns permission instead of the original.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Version: 8.x-1.1 » 8.x-1.x-dev
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

The last submitted patch, 2: mailchimp_campaign_permissions.patch, failed testing.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
FileSize
mailchimp-campaigns-routing-permissions-2746685-14.patch3.04 KB
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: mailchimp-campaigns-routing-permissions-2746685-14.patch, failed testing.

The last submitted patch, 14: mailchimp-campaigns-routing-permissions-2746685-14.patch, failed testing.

The last submitted patch, 14: mailchimp-campaigns-routing-permissions-2746685-14.patch, failed testing.

The last submitted patch, 14: mailchimp-campaigns-routing-permissions-2746685-14.patch, failed testing.

  • amyvs committed f33af68 on 8.x-1.x authored by ChrisGrewe 
    Issue #2746685 by ChrisGrewe, asrob: Mailchimp Campaigns routing...
amytswan’s picture

amytswan CreditAttribution: amytswan at ThinkShout commented
Status: Needs work » Fixed

Thanks @ChrisGrewe for the solid use case and the patch! It's currently up on our 8.x-1.x-dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.