The module denies access to regular user with 'clone own node' permission.

Problem

In NodeCloneFormController::access() node owner id (uid) is queried in a way which results in NULL. Hence following comparisons wont work.

Solution

Replace

$node->uid->value

with

$node->getOwner()->id()
CommentFileSizeAuthor
#7 2746363-fix-broken-access-7.patch751 bytesmallezie
#4 2746363-3.patch751 bytesrajeshwari10
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ragnarkurm created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Assigned: Unassigned » rajeshwari10
ragnarkurm’s picture

ragnarkurm CreditAttribution: ragnarkurm as a volunteer and at Wunder commented
FileSize
2746363-fix-broken-access.patch751 bytes
rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Status: Active » Needs review
FileSize
2746363-3.patch751 bytes

Changes as per suggestion.

Thanks!!

ragnarkurm’s picture

ragnarkurm CreditAttribution: ragnarkurm as a volunteer and at Wunder commented

Just out of curiosity - what is patch naming convention (why 2746363-fix-broken-access.patch -> 2746363-3.patch) ?

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Needs review » Reviewed & tested by the community

I successfully applied rajeshwari10's patch, but as I can see ragnarkurm's one is good as well. RTBC'ed!

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie at Wunder commented
Status: Reviewed & tested by the community » Needs review
FileSize
2746363-fix-broken-access-7.patch751 bytes

Patch would not apply with composer patches. Rerolled.