Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Remove depreciated methods and unused imports
Comment | File | Size | Author |
---|---|---|---|
#18 | 2746161-18.patch | 16.62 KB | Sahana _N |
#15 | Screen Shot 2019-12-30 at 4.16.37 PM.png | 205.16 KB | snehalgaikwad |
#13 | interdiff_10-13.txt | 114.91 KB | nikitaaswani |
#13 | remove-depreciated-methods-and-unused-imports-2746161-13.patch | 129.1 KB | nikitaaswani |
#10 | remove-depreciated-methods-and-unused-imports-2746161-10.patch | 35.42 KB | nikitaaswani |
Comments
Comment #2
neerajskydiver CreditAttribution: neerajskydiver at Valuebound commentedComment #3
fornigam CreditAttribution: fornigam as a volunteer and at Cybage Software Pvt Ltd. commentedUpdated info.yml file with proper format with comment.
Thanks, Nigam
Comment #4
neerajskydiver CreditAttribution: neerajskydiver at Valuebound commentedRemoved depreciated methods and unused code.
Comment #5
heykarthikwithu@fornigam, i saw you are a new contributor, for further issues make sure you work on unassigned issues,
As you are new contributor refer https://www.drupal.org/node/945492 for more details on how to work the issue queue.
Comment #6
lhridley CreditAttribution: lhridley at Promet Source commentedPatch 2746161-4.patch is invalid and should be removed.
Comment #7
nkoporecTested both patches.The first one #3 is not related to this issue and should be deleted.Tried the #4 patch but it doesn't apply(issue with applying in FieldValidationConstraintValidator.php) after fixing the patch and reapplying it I found out there's an error in FieldValidationRuleFormBase where entityManager->getFieldDefinitions() is replaced with entityTypeManager which doesn't have this method(it should be EntityFieldManager) so the page breaks when you try to add a new rule.Marking as Need Work.
Comment #8
nkoporecComment #9
nikitaaswani CreditAttribution: nikitaaswani as a volunteer and at QED42 commentedComment #10
nikitaaswani CreditAttribution: nikitaaswani as a volunteer and at QED42 commentedRemoved depreciated methods and unused code/imports.
Comment #11
pratik_kamble@nikitaaswini There were coding standard issues already in the module. And in the patch as well there are coding standard issues. Please execute the PHPCS tool and check for it.
Also, we don't really need to inject the messager service instead we can use $this->messenger->addMessage() method.
FieldValidationRuleSetAddForm.php we don't need to declare the protected $entityTypeManager;. It is already present in the parent class.
Comment #12
nikitaaswani CreditAttribution: nikitaaswani as a volunteer and at QED42 commentedComment #13
nikitaaswani CreditAttribution: nikitaaswani as a volunteer and at QED42 commentedComments in #11 addressed
Comment #14
snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commentedComment #15
snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commentedI tried applying this patch. I'm getting errors while creating new ruleset and deleting rule. Errors are for addMessage method of messenger.
Comment #16
snehalgaikwad CreditAttribution: snehalgaikwad at QED42 commentedComment #17
Sahana _N CreditAttribution: Sahana _N commentedComment #18
Sahana _N CreditAttribution: Sahana _N commentedPlease review the patch. I removed the deprecated methods.
Comment #19
heykarthikwithuReviewed the patch, looks good..
Comment #20
Sahana _N CreditAttribution: Sahana _N at Specbee commentedComment #21
g089h515r806 CreditAttribution: g089h515r806 commented