In #2647160: Figure out best module name, it was decided that the module name should be "Field Collection Switch View Mode". The .info file needs to be updated. Patch to follow.

CommentFileSizeAuthor
#4 fc_view_mode-update-module-name-2745053-3.patch2.84 KBloopduplicate
#2 fc_view_mode-update-module-name-2745053-2.patch414 bytesloopduplicate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

loopduplicate created an issue. See original summary.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Assigned: loopduplicate » Unassigned
Status: Active » Needs review
FileSize
fc_view_mode-update-module-name-2745053-2.patch414 bytes

Here's a patch :)

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Looks good! Thanks. :)

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Reviewed & tested by the community » Needs review
FileSize
fc_view_mode-update-module-name-2745053-3.patch2.84 KB

Looks like I missed a bunch of places in other module files where the name needs updating. Here's a new patch.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Ah, good catch. :) I applied the patch and then did:

grep -ri 'field collection view mode' .

and I don't see any remnants of the old name so RTBC for real.

  • loopduplicate committed 5e0c4af on 7.x-1.x 
    Issue #2745053 by loopduplicate, Kristen Pol: Update module name
loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Reviewed & tested by the community » Fixed

Alright :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented

Fixing attribution