When running a migrate task a JS error appears in the console warning about anonymous functions. The contents of hosting_migrate.js is not wrapped with: 

(function($) {
// Stuff here 
})(jQuery);

Patch coming.

CommentFileSizeAuthor
#7 jquery-error-2744961-7.patch1.21 KBjeremyr
#5 jquery-error-2744961-5.patch2.44 KBjeremyr
#2 jquery-error-2744961-1.patch2.57 KBjeremyr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jeremyr created an issue. See original summary.

jeremyr’s picture

jeremyr CreditAttribution: jeremyr as a volunteer commented
FileSize
jquery-error-2744961-1.patch2.57 KB
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Ergon Logic Enterprises for Aegir Cooperative commented
Status: Needs review » Needs work

This appears to have broken the "Compare platforms" link.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Ergon Logic Enterprises for Aegir Cooperative commented

Note that the "Compare platforms" link currently drops us out of the modal dialog, and thus is already broken. It ought to provide us the comparison table, within the modal, and allow the 'back' link to return us to the migration form.

jeremyr’s picture

jeremyr CreditAttribution: jeremyr as a volunteer commented
FileSize
jquery-error-2744961-5.patch2.44 KB

I see what I did... wrapped the whole damn thing when only the first part of should have been. Fixed in the attached patch.

This issue also uncovered a secondary problem with the Overlay. In testing the original problem I was not signed in as User 1 but rather a secondary account. User's who are not logged in as User 1 do not have permission to use the Overlay (modal dialog). This is why I didn't notice it was falling out of the modal. Also confirming that this bug was present prior to my patch. In testing a non-patched version as User 1 it still falls out.

Now that the topic is broached, and possibly deserves a distinct issue, can we make the use of the Overlay module optional? My personal preference is to disable the module when ever possible. Apparently one can get around the use of the Overlay by creating a secondary administrative user.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Ergon Logic Enterprises for Aegir Cooperative commented

The latest patch introduces some white-space issues, both incorrect indentation, and some trailing.

User's who are not logged in as User 1 do not have permission to use the Overlay (modal dialog).

Hmm, that shouldn't be. I filed a bug report for that: #2745211: Modal dialogs only work for admin users

Now that the topic is broached, and possibly deserves a distinct issue, can we make the use of the Overlay module optional?

You can uncheck the "Use the overlay for administrative pages." option on your account settings to disable Overlays on a user-by-user basis.

As for removing it as a dependency, I'd be fine with making it completely optional, assuming we make whatever adjustments might be necessary. One interesting approach might be to move all the code that deals with the Overlay into a separate module that mostly consists of hook_form_alter()s to add it wherever needed. That module could then be enabled by default in the install profile, but not depended-upon by any other modules.

jeremyr’s picture

jeremyr CreditAttribution: jeremyr as a volunteer commented
FileSize
jquery-error-2744961-7.patch1.21 KB

Let's try that patch one more time...

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commented
Status: Needs work » Needs review
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commented

I can't reproduce the 'warning about anonymous functions'

but do see 

TypeError: Drupal.modalFrame is undefined 
Drupal.modalFrame.open(options);
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commented
Assigned: jeremyr » Unassigned

Who can review this? Jon?

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commented
Status: Needs review » Closed (outdated)

Please re-open if this can still be re-produced.