Instead of implementing our own conversion functions we should leverage the existing ones of Solarium.

BTW there's a pending improvement: https://github.com/solariumphp/solarium/pull/429

CommentFileSizeAuthor
#6 2743917_reroll.patch2.06 KBmkalkbrenner
#4 date_utilities-2743917-3.patch2.02 KBblazey
#3 date_utilities-2743917-3.patch0 bytesblazey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Title: Use Solarium's utilities for date convertions » Use Solarium's utilities for date conversions
blazey’s picture

blazey CreditAttribution: blazey as a volunteer commented
Status: Active » Needs review
FileSize
date_utilities-2743917-3.patch0 bytes

Attaching patch that changes the way date is converted in addIndexField and formatFilterValue methods of Drupal\search_api_solr\Plugin\search_api\backend\SearchApiSolrBackend.

There are two more references to 'date' in the module, one in extractResults and the other in extractFacets. Both seem to be handling data returning from solr, though.

blazey’s picture

blazey CreditAttribution: blazey as a volunteer commented
FileSize
date_utilities-2743917-3.patch2.02 KB
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Status: Needs review » Needs work
Issue tags: -sprint +Needs reroll
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Needs review
FileSize
2743917_reroll.patch2.06 KB

I think, that's the correct re-roll

  • mkalkbrenner committed 3e226fa on 8.x-1.x authored by blazey 
    Issue #2743917 by blazey, mkalkbrenner: Use Solarium's utilities for...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH commented
Status: Needs review » Fixed

committed, thanks for contributing!

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.