Problem / Motivation
Taxonomy Term Edit Link field handler ignoring settings from `Output this field as a link` (rewrite results).

Solution
Patch attached. Tested on latest releases of Drupal 7 on dev version of Views 7.x-3.x-dev.

CommentFileSizeAuthor
#8 views-fix_term_link_edit_fix_rewrite_results_settings-2742805-8-D7.patch2.14 KBabramm
#6 Selection_031.png63.88 KBabramm
#4 2742805-4-views-term_link_edit-fix_rewrite_results_settings-7.x-3.x.patch2.15 KBbohart
views-term_link_edit-fix_rewrite_results_settings-7.x-3.x.patch2.04 KBbohart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bohart created an issue. See original summary.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Active » Needs work 
+++ b/modules/taxonomy/views_handler_field_term_link_edit.inc
@@ -44,19 +44,22 @@ class views_handler_field_term_link_edit extends views_handler_field {
+  function render_link($data, $values) {

Missed docblock

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Drupal Ukraine Community for Drupal Ukraine Community commented 
+++ b/modules/taxonomy/views_handler_field_term_link_edit.inc
@@ -44,19 +44,22 @@ class views_handler_field_term_link_edit extends views_handler_field {
+      $this->options['alter']['path'] = "user/$data/edit";

this needs to be taxonomy/../edit link

bohart’s picture

bohart
Location Lutsk, Ukraine
CreditAttribution: bohart as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Needs work » Needs review
FileSize
2742805-4-views-term_link_edit-fix_rewrite_results_settings-7.x-3.x.patch2.15 KB

Updated patch attached.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Code looks good. Can be merged.

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
CreditAttribution: abramm at DevBranch commented
FileSize
Selection_031.png63.88 KB

Works for me; re-checked at simplytest.me to ensure it's not affected by other modules.
screenhost

MrPeanut’s picture

MrPeanut CreditAttribution: MrPeanut commented

Patch from #4 no longer applies.

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
CreditAttribution: abramm at DevBranch, Drupal Ukraine Community commented
FileSize
views-fix_term_link_edit_fix_rewrite_results_settings-2742805-8-D7.patch2.14 KB

Hi MrPeanut,

Here's a re-roll for latest 7.x-3.x-dev.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

Committed. Thanks.

  • DamienMcKenna committed 9b453d6 on 7.x-3.x authored by bohart 
    Issue #2742805 by bohart, abramm: Taxonomy Term Edit Link field handler...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

salbertz’s picture

salbertz CreditAttribution: salbertz commented

Hmm - now the field is no longer rendered as link at all by default (i.e. if "output as link" is _not_ checked) - which is not what you would expect of a field called "term edit link". The path is not altered as intended by setting $this->options['alter']['path'], but a simple string returned by $this->render(). (Tested with Drupal 7.67 and views 3.23.)

vaccinemedia’s picture

vaccinemedia CreditAttribution: vaccinemedia commented

@salbertz I am also seeing this issue which is what led me here to find I'm not going a bit crazy ;) I was wondering why all of my edit links had stopped working.