Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When I edit a node and set an exception to the date repeating, and infinite loop occurs. Running Drupal 5.7, PHP 5.2.5, date field, jscalendar, UTC timezone for everything required.
Comment | File | Size | Author |
---|---|---|---|
#22 | date-bug.rar_.tar_.gz | 901.42 KB | pkej |
Comments
Comment #1
jscheel CreditAttribution: jscheel commentedSorry, that last piece was "...UTC for everything, field is required".
Comment #2
KarenS CreditAttribution: KarenS commentedEverything works fine as long as you don't try to set an exception date, right? I was just running into this, too. Exception dates used to work fine, but something has changed somewhere and I need to track it down.
Comment #3
KarenS CreditAttribution: KarenS commentedTry again with the latest cvs. I just make a fix to the date popup module that seems to have fixed this, too.
Comment #4
jscheel CreditAttribution: jscheel commentedNote: this works fine on my local dev environment, but the bug appears on the live server. Both are running the same versions of everything, except mysql on local is 5.0.45 and on live is 5.0.22. I also noticed that the dates get saved without the "T" on my local environment but they have the "T" on the live server. Both dev and live are on same timezone as well.
Comment #5
jscheel CreditAttribution: jscheel commentedHmm, grabbed latest version, but now I'm getting a WSOD. "Only variables can be passed by reference in ../sites/all/modules/date/date_copy/date_copy.module on line 193"
Comment #6
jscheel CreditAttribution: jscheel commentedJust to test, I pushed just the date_popup.module fix (to get around the WSOD), but it is still ending in an infinite loop.
Comment #7
jscheel CreditAttribution: jscheel commentedInterestingly, when I set the widget to use select list instead of the jquery popup, the date repeating fields still used the jquery popup.
Comment #8
KarenS CreditAttribution: KarenS commentedDate copy module? There is no reason Date Copy would be doing anything here. I can't replicate this at all.
Comment #9
KarenS CreditAttribution: KarenS commented#7 is not a bug, it's by design for now and there's an issue about matching the date repeat widget to the date select widget, so that's not a part of this issue.
Comment #10
KarenS CreditAttribution: KarenS commentedLine 193 of Date Copy is not passing a reference -- it's a form element that should only show up at admin/content/date or admin/content/date/import (the Date Import/Export paths). There is no other place that would be called, definitely not from a date repeat widget. Are you sure you've got the right code?
Comment #11
jscheel CreditAttribution: jscheel commentedOh, I'm a retard. I'm checking out trunk, which is probably your 6.x development. Sorry! Let me try the right branch :P
Comment #12
jscheel CreditAttribution: jscheel commentedAlright, I'm using the lastest from the 5.x branch. Now I'm getting this when viewing the node:
Also, adding exceptions is still causing an infinite loop.
Comment #13
jscheel CreditAttribution: jscheel commentedThe sql error looks like it's happening from a view in a block on the site that uses the date filters, not from viewing the node.
Comment #14
KarenS CreditAttribution: KarenS commentedYou need to find that view and pull it up and make sure it's set up right. Save it, even if it looks right. Then see if the error goes away.
Comment #15
jscheel CreditAttribution: jscheel commentedHmm same sql error. Also still getting the infinite loop on the date exceptions. I know this is a separate issue, but just for the record, here is my view that is getting a sql error:
Comment #16
KarenS CreditAttribution: KarenS commentedI am absolutely unable to get any endless loop problems in the latest code. I've tried every combination of date repeat I can come up with and they all work fine. I've tried all kinds of widgets, formats, with and without timezones, etc, etc. everything works perfectly for me.
I've made commits today, so make sure you have the latest code with those commits so we're not talking apples and oranges, clear all your caches, pull up your date field, double check it's settings, and save it (even if you made no changes).
Then try again.
Comment #17
jscheel CreditAttribution: jscheel commentedJust to test everything out, I created a fresh new site, with just CCK and Date (latest code from cvs) installed. I set the site timezone to UTC and turned off user timezones. I'm still getting the problem. I've tried changing the "to" date field from optional to never, but that didn't help. Here is an export of the content type on the test site I set up:
Thanks a lot for all of the help you are giving me KarenS :)
Comment #18
KarenS CreditAttribution: KarenS commentedStill unable to reproduce this problem. I've tried all kinds of things, including switching from PHP 5.2 to PHP 4, and never have a problem.
My only other idea is that it's related to http://drupal.org/node/273344. Try giving the date a default value of 'now' instead of blank and see if that makes any difference. Also try switching from the Date Popup to a Date Select widget. And try a couple different types of dates (an ISO date and a datestamp date) to see if that makes any difference.
Anything you can do to narrow down exactly what combination causes the problem would help.
Comment #19
jscheel CreditAttribution: jscheel commentedWill do. I'm going to be gone for the next week, but if I can get to the computer at all, I'll work on it. Thanks again for all your help!
Comment #20
KarenS CreditAttribution: KarenS commentedI was finally able to find a way to get an infinite loop, but only using PHP4 and the PHP4 wrapper code. I uncovered that problem when fixing http://drupal.org/node/272523 where I found a situation where the wrapper date_modify() function could get stuck on invalid values. I still have not been able to get this to happen using PHP 5.2.
Comment #21
KarenS CreditAttribution: KarenS commentedThere was another report at http://drupal.org/node/283706. I'm still unable to reproduce this, so as much info as possible will help.
Comment #22
pkej CreditAttribution: pkej commentedOK, here is a step by step of my problem:
Downloads:
Enable the modules:
Creating content type:
It seems that I have to enable at least one core CCK field type to be able to add any fields. I selected to enable the "CCK Text" module.
Create a node:
Well, it didn't work now, I got the following error message:
For your convinience I have added a rar archive (change the extension to .rar) of my date-bug testing. Included is the "Demo Site" module. You should just have to extract the archive into an XAMPP installation, change the settings.php file, install and enable the "Demo Site" module, then you should be able to reset site to the state it was in after I performed the above steps.
My testing seems to indicate that the timeout probably is due to one of the other "standard"-modules I use.
Comment #23
KarenS CreditAttribution: KarenS commentedpkej - this is very helpful but I can't do anything with your file. I don't know what '.rar' extensions are supposed to do but it doesn't work on my system. I'm using windows and I can handle .zip and .gz.
What makes you think your timeout is coming from some other module? Do you have any idea which one it is so I can try it?
Comment #24
pkej CreditAttribution: pkej commentedSearch for Unrar on google, or winrar. Unfortunately compressing with zip made the file slightly bigger than the upload limit of 1 MB, and on the Windows machine where I tested at work, tar and gz are not available.
Just speculating as for the infinite loop I experienced in http://drupal.org/node/283706. The reason I speculate about that is that on both my first on my Mac and my second test at work PC, I experienced the infinite loop. Both were using quite a few modules, I am trying to find an effective way to do n-m relationships where the relationships are nodes, without writing code. That's why I believe it might be the interaction with some of those other modules that might have influenced the infinite loop.
For example, could the developer modules lead to this? Or how about some of the java scripts in date module, which I didn't turn on for the above test. How about jquery_update. And on at least one of the test systems I had the event module installed as well.
I still have those installations, so I could zip them down, but we need to find an FTP site where I can upload it and where you can download, b/c they are way too big to be attached to an issue.
I'll try to load up on the modules one by one on the date-bug installation from yesterday and see if I reach the infinite loop at some point.
Comment #25
KarenS CreditAttribution: KarenS commentedI did some significant work on the Date Repeat widgets, so hopefully this is fixed. You either need the current cvs -dev version, or wait until later day when I plan to roll a new rc.
Comment #26
pkej CreditAttribution: pkej commentedLooking forward to the rc, I will do some extensive testing at that point! Thanks for the great work.
Comment #27
KarenS CreditAttribution: KarenS commentedI just tagged a new release with these fixes.
Comment #28
jscheel CreditAttribution: jscheel commentedKarenS, sorry I fell of the face of the planet with this. I'm super excited to try these new fixes!
Comment #29
pkej CreditAttribution: pkej commentedI have had no repeat of the infinite loop after using the latest version in 6.x. I haven't gone back and tried in 5.x, been busy at work for the fall schedule.
Comment #30
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.