There is still a lot of deprecated code.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Saphyel created an issue. See original summary.

Saphyel’s picture

Saphyel’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2742031_2_update_code.patch, failed testing.

The last submitted patch, 2: 2742031_2_update_code.patch, failed testing.

The last submitted patch, 2: 2742031_2_update_code.patch, failed testing.

The last submitted patch, 2: 2742031_2_update_code.patch, failed testing.

amateescu’s picture

+++ b/xmlsitemap.module
@@ -1923,7 +1923,7 @@ function xmlsitemap_sitemap_multiple_update(array $smids) {
+  $destination = \Drupal::destination()->getAsArra();

Missing 'y' :)

slasher13’s picture

slasher13’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 2742031-9-update-code.patch, failed testing. View results

voleger’s picture

KarimB’s picture

KarimB’s picture

Status: Needs work » Needs review
RajeevChoudhary’s picture

I tested this for these function drupal_set_message() and drupal_realpath().
Looks good and works fine.

KarimB’s picture

Status: Needs review » Reviewed & tested by the community
Dave Reid’s picture

Status: Reviewed & tested by the community » Needs work

What is the minimum core version that these changes would need? 8.4? 8.5? Let's please be sure to include that in our composer.json and xmlsitemap.info.yml.

kkalaskar’s picture

@Dave Reid as per your suggestion I added dependencies into the info.yml file. Please review the attached patch. I used update_deprecated_functions-2742031-13.patch this patch file and added the new line into info file.

kkalaskar’s picture

Status: Needs work » Needs review
Nikhilesh Gupta’s picture

Status: Needs review » Needs work

The last submitted patch, 20: update_deprecated_functions-2742031-19.patch, failed testing. View results

Nikhilesh Gupta’s picture

Assigned: Unassigned » Nikhilesh Gupta
Nikhilesh Gupta’s picture

Status: Needs review » Needs work

The last submitted patch, 23: update_deprecated_functions-2742031-20.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

voleger’s picture

Title: Update deprecated functions » Replace deprecated code
Status: Needs work » Needs review
FileSize
46.05 KB
36.85 KB

Replace more deprecations.

Status: Needs review » Needs work

The last submitted patch, 25: update_deprecated_functions-2742031-25.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

voleger’s picture

includes codesniffer_fixes.patch

Status: Needs review » Needs work

The last submitted patch, 27: update_deprecated_functions-2742031-27.patch, failed testing. View results

Dave Reid’s picture

Status: Needs work » Closed (duplicate)

Merging this with #3042673: Drupal 9 Ready