CommentFileSizeAuthor
#12 calendar-change_datetime_dependency-2741259-12.patch346 bytesszeidler
#5 composer-json-2741259-5.patch667 bytesShreya Shetty
#3 composer-json-2741259-3.patch540 byteswidukind
#2 composer-json-2741259-2.patch459 bytesShreya Shetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shreya Shetty created an issue. See original summary.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commented
Status: Active » Needs review
FileSize
composer-json-2741259-2.patch459 bytes
widukind’s picture

widukind CreditAttribution: widukind as a volunteer commented
FileSize
composer-json-2741259-3.patch540 bytes

LGTM overall. FWIW, I added the keywords and support.source attributes.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Needs review » Needs work
Issue tags: +DevDaysMilan

Thanks for the patch!

The composer.json file also needs to list dependencies, like views_templates, no?

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commented
Status: Needs work » Needs review
FileSize
composer-json-2741259-5.patch667 bytes

Yes we should ..Thank You for the review . I have made the changes

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Needs review » Fixed

Alright, thank you!

Committed and pushed to 8.x-1.x.

sukanya.ramakrishnan’s picture

sukanya.ramakrishnan CreditAttribution: sukanya.ramakrishnan commented

Hmm, getting errors with downloading the module.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package drupal/calendar_datetime could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.
 Use --force to continue.

Should the requirement for drupal/calendar_datetime be there? it is a submodule of this module right?

sukanya.ramakrishnan’s picture

sukanya.ramakrishnan CreditAttribution: sukanya.ramakrishnan commented

Update, i had to remove the requirement for drupal/calendar_datetime to make this work.

Thanks
Sukanya

miscellainiac’s picture

miscellainiac CreditAttribution: miscellainiac commented

Same here. Although in my case, I replaced the requirement for drupal/calendar_datetime to just drupal/datetime. Can we get this issue re-opened and looked at? At the very least, it would be nice to know which one is actually required, if either of them actually are.

I can confirm that this is happening with Drupal 8.1.6; I haven't tried yet with a previous version of core.

miscellainiac’s picture

miscellainiac CreditAttribution: miscellainiac commented
Status: Fixed » Needs work
szeidler’s picture

szeidler CreditAttribution: szeidler at Ramsalt Lab commented
Status: Needs work » Needs review
FileSize
calendar-change_datetime_dependency-2741259-12.patch346 bytes

At the moment, the composer.json is breaking the composer workflow, because of missing package information for the calendar_datetime submodule.

For me it seems, as the submodule is not a real requirement anymore for the base calendar module anymore, but the Drupal Core datetime module is.
For that reason the composer requirement should be changed.

chris.smith’s picture

chris.smith CreditAttribution: chris.smith at Portage CyberTech commented
Status: Needs review » Reviewed & tested by the community

I can confirm that the patch in #12 solves the issue in #8.

  • pjonckiere committed cb0ad00 on 8.x-1.x authored by szeidler 
    Issue #2741259 by Shreya Shetty, szeidler, widukind, sukanya....
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +drupalironcamp

Seems like a reasonable thing to do. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.