Problem/Motivation

Currently the override_node_options module does not work with views bulk operations.

Proposed resolution

Replace override_node_options_form_alter with hook_entity_field_access_alter() for the fields where this is possible.

CommentFileSizeAuthor
#9 replace-2741193-9.patch2.89 KBJeroenT
#9 interdiff-2741193-6-9.txt1.95 KBJeroenT
#6 replace-2741193-6.patch2.78 KBJeroenT
#6 interdiff-2741193-2-6.txt1.21 KBJeroenT
#2 replace-2741193-2.patch2.79 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT created an issue. See original summary.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
FileSize
replace-2741193-2.patch2.79 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Title: Replace override_node_options_form_alter with hook_entity_field_access_alter » Replace override_node_options_form_alter() with hook_entity_field_access_alter().

Status: Needs review » Needs work

The last submitted patch, 2: replace-2741193-2.patch, failed testing.

The last submitted patch, 2: replace-2741193-2.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
FileSize
interdiff-2741193-2-6.txt1.21 KB
replace-2741193-6.patch2.78 KB

This should fix the failing tests.

Status: Needs review » Needs work

The last submitted patch, 6: replace-2741193-6.patch, failed testing.

The last submitted patch, 6: replace-2741193-6.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
interdiff-2741193-6-9.txt1.95 KB
replace-2741193-9.patch2.89 KB

The revision checkbox is not a field but just a form item. So this should stay in override_node_options_form_alter().

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Issue summary: View changes
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies as a volunteer commented

Thanks @JeroenT for the patches!

The latest patch looks OK at a glance. I'll apply it to my local D8 site and do a quick manual test, probably over the weekend.

  • opdavies committed f473173 on 8.x-2.x authored by JeroenT 
    Issue #2741193 by JeroenT: Replace override_node_options_form_alter()...
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies as a volunteer commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.