Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.DHTML Menu will become compatible with D7 once the API gets frozen. In this issue, I will track things that need to be fixed.
- 6.x-2.x-dev appears functional in 7.x-dev as it is now.
- The registry triggers some notices on enabling the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | dhtml_menu_7_remake-273872-11.patch | 23.36 KB | cburschka |
| #7 | dhtml_menu-d7-273872-7.patch | 16.47 KB | cburschka |
| #6 | dhtml_menu-d7-273872-6.patch | 17.93 KB | cburschka |
| #5 | dhtml_menu-d7-273872-5.patch | 17.79 KB | cburschka |
| #4 | dhtml_menu-d7-273872-4.patch | 1.14 KB | cburschka |
Comments
Comment #1
cburschkaThe settings form won't display. The module probably needs to make sure the registry knows about this form and the included file it is in.
Comment #2
cburschkaThis patch will make DHTML Menu compatible with the current CVS HEAD.
DHTML Menu's HEAD is still compatible with 6.x, and will remain so for a while yet.
Comment #3
cburschkaSimilar changes will be necessary for 6.x-3.x, but with the rewrite I'm pretty sure it doesn't apply anymore.
Also, HEAD will become D7-compatible immediately after 6.x-3.0 is released as stable. That will happen once I get a few localizations in.
Comment #4
cburschkaSuperficial reroll.
Comment #5
cburschkaThis patch really takes advantage of the new registry and code separation techniques. It is also compatible with this patch: #259412: Total module system revamp
Comment #6
cburschkaRemoved some init voodoo that was not necessary.
Also, a slight improvement to the Javascript that might in fact get into 3.x-dev first.
Comment #7
cburschkaI committed some fixes into HEAD so they don't need to be done twice. Here is the same patch without these fixes.
Comment #8
cburschkahook_init does not run without the module revamp patch. As I don't want to spend time reverting part of the changes, this patch will be postponed until module revamp lands.
Comment #9
cburschkaPending #259412: Total module system revamp.
Comment #10
cburschkaFor 7.x, obviously.
Comment #11
cburschkaThis patch does a lot more than fix compatibility. It introduces these additional features:
- Set animation effects and speed
- Choose between these methods of coexisting with static navigation: Doubleclick (legacy), Pseudo-children (still the default), Making only the bullet clickable and leaving the link static (which has been desired for years by some).
Feel the awesomeness.
Comment #12
cburschkaCommitted to HEAD.
The downside is that from now on, patches to D6 need to be ported up.