I see the below on all migrations on recent CiviCRM 4.6.x platforms.

[...]
CiviCRM: finished _provision_civicrm_fixpermissions()	
Starting with v4.6.14 -> v4.6.16 upgrade ..	
CiviCRM: upgrade output: Upgrade outputs:	
CiviCRM: finished _provision_civicrm_upgradedb()
[...]

The third line ("upgrade output: Upgrade outputs") is a warning, but I'm pretty sure a false positive. I suspect it's in CiviCRM's Drush commandfile. Unfortunately, it means having to manually check all migrations, in case there's a real warning buried somewhere...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic created an issue. See original summary.

ergonlogic’s picture

Status: Active » Fixed

Actually, it turns out that it's coming from both _provision_civicrm_upgradedb() and drush_civicrm_upgrade_db(). We appear to be attempting to do some output buffering, but little of any use is being returned. Either way, I certainly don't think this deserves to be a warning by default.

Perhaps for older installations, it was calling a core CiviCRM function? This'd explain the OB stuff. But when calling another drush function, it doesn't make as much sense.

I've cleaned this up in 671b53e, which has resolved this warning for me.

bgm’s picture

Status: Fixed » Needs work

I would prefer keeping this as a "info" message, but OK to not make it a warning.

drush_civicrm_upgrade_db() will output the upgrade notes using this:

drush_print("Upgrade outputs:\n" . $result['text']);

That's why hosting_civicrm was capturing the buffered output.

#2734933: CIVICRM_UPGRADE_ACTIVE true fails on AEgir tasks will also avoid running the upgrade uselessly, but agreed that displaying them as a "warning" is not productive, it trains people to ignore all warnings.

ergonlogic’s picture

Status: Needs work » Needs review
FileSize
1.24 KB

I reverted my previous commit, which had just ignored the output.

I've attached a patch that reduces the severity of the log to 'info', and cleans up some code duplication in the process.

ergonlogic’s picture

New patch; fixes mis-placed parenthesis.

ergonlogic’s picture

See this PR on Github for a rerolled commit: https://github.com/mlutfy/hosting_civicrm/pull/12

  • ergonlogic committed 371ce4d on 7.x-3.x
    Issue #2738069: Fix false positive warnings on all migrations.