An obvious place for users to put global Drush options (as per the Drush docs) would be /var/aegir/.drush/drushrc.php. Unfortunately, since we generate that file, any customizations will be lost at the next hostmaster site verify.

Let's add a locally included file for this purpose, as we do elsewhere: /var/aegir/.drush/local.drushrc.php

CommentFileSizeAuthor
#2 provision-allow_drush_overrides-2737785-1.patch1.23 KBergonlogic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ergonlogic created an issue. See original summary.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Ergon Logic Enterprises for Aegir Cooperative commented
FileSize
provision-allow_drush_overrides-2737785-1.patch1.23 KB

Patch attached, and pushed to dev/2737785 branch.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic at Ergon Logic Enterprises for Aegir Cooperative commented
Project: Hostmaster (Aegir) » Provision
Status: Active » Needs review

Moving to proper queue and status.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented

I've used /etc/drushrc.php in a few such occasions.

Moving our generated rc to aegir.drushrc.php and then on installation adding an include line to drushrc.php might be an even nicer way ... but probably more a change for 4.x

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Needs review » Reviewed & tested by the community

moved dev branch to github as 'dev/2737785-local-drushrc' - https://github.com/aegir-project/provision/pull/4

And I added one commit to make '/var/aegir' a variable as we do on more places.

PS: the branch should probably have been named 'feature/2737785-local-drushrc'

  • helmo committed ebcdd41 on 7.x-3.x authored by ergonlogic 
    Issue #2737785 by ergonlogic: Provide a stable location for Drush...
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Reviewed & tested by the community » Fixed

committed

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

@helmo

Not sure why there is this line:

$this->data['aegir_root'] = DRUPAL_ROOT;

As far as I know, aegir_root != DRUPAL_ROOT ?

/var/aegir already has its variable: aegir_root, but it is never DRUPAL_ROOT..

Maybe I have missed something?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Fixed » Needs work

Agreed; that looks strange.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Needs work » Fixed

Good catch ... Reverted ... As it was not really related to this issue I'll set the status back to fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.