Problem/Motivation

The "address requirement level" setting found on the recurly configuration form (admin/config/services/recurly) is not being respected by the payment forms and always defaults to the full address form elements.

Proposed resolution

Update the payment form to respect the "address requirement level" settings.

CommentFileSizeAuthor
#11 address-requirement-setting-not-working-2736929-11.patch4.9 KBwalangitan
#5 address-requirement-setting-not-working-2736929-4.patch4.89 KBdsbrianwebster
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsbrianwebster created an issue. See original summary.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Issue summary: View changes
dsbrianwebster’s picture

dsbrianwebster CreditAttribution: dsbrianwebster commented

@markdorison -- thanks for cleaning up the issue description. I got this working, just need to clean up the code and make a patch. Will submit tonight, or tmr morning latest.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented

@dsbrianwebster Think you will still be able to submit a patch? Really appreciate the assistance.

dsbrianwebster’s picture

dsbrianwebster CreditAttribution: dsbrianwebster commented
FileSize
address-requirement-setting-not-working-2736929-4.patch4.89 KB

@markdorison -- yes, sorry, the short week has been a little crazy over here. Patch attached. Functionality is in place. Feel free to clean up patch/code as needed. This gets all address settings (full, zipstreet, zip and none) as well as the "Hide VAT number input box from checkout page" (bonus) working :)

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Active » Needs review
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic for TheaterMania.com, Inc. commented

This is looking good in my testing. I have come across an issue about missing module messages with the patch that's related to the 7.50 core release. The issue is #2736929: Address Requirement Setting Not Working has code which is changed there but not in this patch yet, so the patch may need to be re-rolled once that gets committed or vice versa.

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic for TheaterMania.com, Inc. commented
Status: Needs review » Reviewed & tested by the community
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Reviewed & tested by the community » Needs work

As @walangitan mentioned, the patch in #5 no longer applies and needs to be re-rolled.

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic for TheaterMania.com, Inc. commented
FileSize
address-requirement-setting-not-working-2736929-11.patch4.9 KB

Rerolled #5.

walangitan’s picture

walangitan CreditAttribution: walangitan at Chromatic for TheaterMania.com, Inc. commented
Status: Needs work » Needs review

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.