Right now we're using simple class names, i.e. Order or Terminal. What if another module defines classes with the same names?

Fatal error: Cannot redeclare class Order

Solution:

Use class names in module namespace, i.e. CommerceNetsOrder

CommentFileSizeAuthor
#3 use_module_namespace-2735033-3.patch12.93 KBzaporylie
#2 use_module_namespace-2735033-2.patch12.74 KBzaporylie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
FileSize
use_module_namespace-2735033-2.patch12.74 KB

Patch fixes class names. Arguments has been reformatted to follow Drupal coding standards (camel_case).

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Active » Needs review
FileSize
use_module_namespace-2735033-3.patch12.93 KB

Other small coding standard issues have been resolved.
In my opinion it is ready to go now.

farald’s picture

farald CreditAttribution: farald commented
Status: Needs review » Reviewed & tested by the community

Nice cleanup. Yes, this is ready to go.

  • zaporylie committed a642503 on 7.x-3.x 
    Issue #2735033 by zaporylie, farald: Use Module namespace for classes
zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.