There's a few cases in core where {@inheritdoc} is @{inheritdoc}, which can cause problems with the annotations parser.

The following are affected:
core/modules/system/src/Tests/Installer/InstallerDatabaseErrorMessagesTest.php
core/modules/system/src/Tests/Installer/InstallerTranslationTest.php
core/modules/system/tests/modules/entity_test/src/Entity/EntityTestNoLabel.php

CommentFileSizeAuthor
#15 2734665-15.patch1.94 KBpashupathi nath gajawada
#11 drupal-typo-2734665-10.patch1.96 KBharsha012
#9 2734665-9.patch1.94 KBrajeshwari10
#2 drupal-annotation_typos-2734665-8.2.x.patch1.94 KBpingers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pingers created an issue. See original summary.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented
Status: Active » Needs review
FileSize
drupal-annotation_typos-2734665-8.2.x.patch1.94 KB

See the attached patch...

Status: Needs review » Needs work

The last submitted patch, 2: drupal-annotation_typos-2734665-8.2.x.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Component: other » system.module
Issue tags: +Documentation
pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

I don't understand the test failures... look unrelated to me.

MiSc’s picture

MiSc CreditAttribution: MiSc at Wunder commented

Looks like tests fails because of issues in 8.2.x-dev.

/mikke

The last submitted patch, 2: drupal-annotation_typos-2734665-8.2.x.patch, failed testing.

MiSc’s picture

MiSc CreditAttribution: MiSc at Wunder commented

Ok, the test fails because the changes make other things fail. Interesting.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Status: Needs work » Needs review
FileSize
2734665-9.patch1.94 KB

I am just giving it a try.

Thanks!!

Status: Needs review » Needs work

The last submitted patch, 9: 2734665-9.patch, failed testing.

harsha012’s picture

harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commented
Status: Needs work » Needs review
FileSize
drupal-typo-2734665-10.patch1.96 KB

added patch

chaitanya17’s picture

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented

Hi @harsha012,

You have missing replacement in one place

- /**
- * @{inheritdoc}
- */
+
protected function setUpSite() {

Status: Needs review » Needs work

The last submitted patch, 11: drupal-typo-2734665-10.patch, failed testing.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

Yeah... still not seeing why this is having problems :)

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Assigned: pingers » pashupathi nath gajawada
Status: Needs work » Needs review
FileSize
2734665-15.patch1.94 KB

HI @Chaitanya Kulkarni,

Please find the updated patch, which also includes the missing replacement from #11.

Status: Needs review » Needs work

The last submitted patch, 15: 2734665-15.patch, failed testing.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

This latest patch is identical to my original patch. I don't think we need to upload another identical patch. We need to find out why it's causing test failures.

shashikant_chauhan’s picture

shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and commented
Status: Needs work » Needs review

retesting last patch.

MiSc’s picture

MiSc CreditAttribution: MiSc at Wunder commented
Status: Needs review » Needs work

As @pingers said, we don need more testing of the same patches. We need to figure out why it fails.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Note that setting the issue "Needs review" does not automatically retest the patch anymore. Since DrupalCI was deployed a couple years back, you need to click the "Add test / retest" link.

The fails look highly unrelated, like maybe HEAD was broken at the time. However, the patch also no longer applies. It's possible that these may have been fixed elsewhere in the meanwhile, so let's check that.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented

Checked both the files were changes are being made in the patch. At both place {@inheritdoc} is there. So this issue shall be closed.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Closed (outdated)

As @xjm and @gaurav.kapoor say, this has been fixed elsewhere so closing this ticket as outdated.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented

Not the same set of problems... but there's more similar typos.

{8.3.x} ~/projects/drupal$ ag -a "\{inheritdoc"
core/modules/shortcut/src/Tests/ShortcutTranslationUITest.php
17:   * {inheritdoc}

core/modules/comment/src/Tests/CommentTranslationUITest.php
31:   * {inheritdoc}

core/modules/menu_link_content/src/Tests/MenuLinkContentTranslationUITest.php
16:   * {inheritdoc}

core/modules/node/src/Tests/NodeTranslationUITest.php
20:   * {inheritdoc}