It would be nice to start bundling https://drupal.org/project/tfa and https://drupal.org/project/tfa_basic

One thing to check is if we can bundle https://github.com/davidshimjs/qrcodejs.git on D.o

CommentFileSizeAuthor
#6 bundle_two_factor-2734589-6.patch999 byteshelmo
#4 bundle_two_factor-2734589-4.patch980 byteshelmo

Comments

helmo created an issue. See original summary.

helmo’s picture

helmo commented
Issue tags: +TFA

The qrcodejs is not on https://www.drupal.org/project/drupalorg_whitelist ...

helmo’s picture

helmo commented

I've put in the whitelist request in #2734837: Request to add qrcodejs

helmo’s picture

helmo commented
Assigned: Unassigned » ergonlogic
Status: Active » Needs work
StatusFileSize
new bundle_two_factor-2734589-4.patch980 bytes

Yay, it's on the whitelist.

Here's a start at expanding our makefile. Trouble is that the tfa_basic module wants qrcode js inside it's own module's include directory.

file_exists(drupal_get_path('module', 'tfa_basic') . '/includes/qrcodejs/qrcode.min.js')

@ergonlogic, can you shine some makefile magic on this?

realityloop’s picture

realityloop commented
Status: Needs work » Needs review

@helmo I've done a patch to add libraries support for qrcodejs to tfa_basic https://www.drupal.org/node/2807953#comment-11668135

helmo’s picture

helmo commented
StatusFileSize
new bundle_two_factor-2734589-6.patch999 bytes

This adds the patch from #2807953: Use libraries module for qrcode.js to the makefile

  • helmo committed d3071e8 on 7.x-3.x 
    Issue #2734589 by helmo: Bundle two factor authentication - tfa
helmo’s picture

helmo commented
Status: Needs review » Fixed

This is now added to the makefile.

Notes:

  • It requires the php5-mcrypt extension
  • It's a normal module to enable, not a hosting feature

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.