Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It would be nice to start bundling https://drupal.org/project/tfa and https://drupal.org/project/tfa_basic
One thing to check is if we can bundle https://github.com/davidshimjs/qrcodejs.git on D.o
Comment | File | Size | Author |
---|---|---|---|
#6 | bundle_two_factor-2734589-6.patch | 999 bytes | helmo |
#4 | bundle_two_factor-2734589-4.patch | 980 bytes | helmo |
Comments
Comment #2
helmo CreditAttribution: helmo at Initfour websolutions commentedThe qrcodejs is not on https://www.drupal.org/project/drupalorg_whitelist ...
Comment #3
helmo CreditAttribution: helmo at Initfour websolutions commentedI've put in the whitelist request in #2734837: Request to add qrcodejs
Comment #4
helmo CreditAttribution: helmo at Initfour websolutions commentedYay, it's on the whitelist.
Here's a start at expanding our makefile. Trouble is that the tfa_basic module wants qrcode js inside it's own module's include directory.
@ergonlogic, can you shine some makefile magic on this?
Comment #5
realityloop@helmo I've done a patch to add libraries support for qrcodejs to tfa_basic https://www.drupal.org/node/2807953#comment-11668135
Comment #6
helmo CreditAttribution: helmo at Initfour websolutions commentedThis adds the patch from #2807953: Use libraries module for qrcode.js to the makefile
Comment #8
helmo CreditAttribution: helmo at Initfour websolutions commentedThis is now added to the makefile.
Notes: