When installing/copying the theme with the drush command 'basic-install' .gitignore is not included. I guess this is a bug?

Without the .gitignore file it's easy to overlook the huge node_modules directory and add it to your repository.

CommentFileSizeAuthor
#2 basic.copy-gitignore-2734435-2.patch585 bytesooystein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ooystein created an issue. See original summary.

ooystein’s picture

ooystein CreditAttribution: ooystein at Ramsalt Lab commented
Status: Active » Needs review
FileSize
basic.copy-gitignore-2734435-2.patch585 bytes

  • ooystein authored 538462e on 8.x-1.x 
    Issue #2734435 by ooystein: .gitignore is not copied in drush basic-...
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs review » Fixed

Hmm that is interesting point. Considering we are only using .node_modules in sass and not for directly loading JS. This patch makes sense to avoid the folder as mentioned in the issue summary.

There is no drush for 7.x so no need to backport.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.