Problem/Motivation

Currently the module name is 'XML sitemap' which is not Drupal naming standard.

Proposed resolution

Let's make it to 'XML Sitemap' so that it follows the standard. Found this issue as part of our automated script doesn't pick the module when we run for 'XML Sitemap - Moderately Critical - XSS - SA-CONTRIB-2016-030'. I know the fix should allow the our script to ingore case. But it's worth fixing module as well.

CommentFileSizeAuthor
#2 2734081-xmlsitemap-2.patch3.74 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Capgemini commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2734081-xmlsitemap-2.patch3.74 KB
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Capgemini commented
Title: Fix the title in .info file » Fix the module names in .info file
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
CreditAttribution: legovaer at Capgemini commented

If we're going to update the name, shouldn't we update the package name as well? E.g.

name = XML sitemap taxonomy
description = Add taxonomy term links to the sitemap.
package = XML sitemap

will become

name = XML Sitemap Taxonomy
description = Add taxonomy term links to the sitemap.
package = XML Sitemap

Just to make sure we have some consistency.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at Capgemini commented

I agree, but fixing that now can break/make other modules under this group can become separate group. Check https://www.drupal.org/node/542202#package for more details.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
CreditAttribution: legovaer at Capgemini commented
Status: Needs review » Reviewed & tested by the community

That makes sense! Just applied the patch in my local environment and executed simpletest using some contributed modules as well. All seems to be working.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2734081-xmlsitemap-2.patch, failed testing. View results