In the EditorImageDialog, buildFom(), list of valid file extensions are hardcoded and limited to: gif, png, jpg, and jpeg.

'file_validate_extensions' => array('gif png jpg jpeg'),

Just like 'Maximum file size' or 'Maximum dimensions', file extension, would be set for each text format. If not specified to use default extensions.

CommentFileSizeAuthor
#39 2733615-39.patch4.98 KBpashupathi nath gajawada
#36 image_extension-2733615-5.patch4.94 KBpericxc
#32 image_extension-2733615-4.patch5.1 KBpericxc
#31 interdiff-image_extension-2733615-1-4.txt1.56 KBpericxc
#28 image_extension-2733615-3.patch5.5 KBpericxc
#24 image_extension-2733615-2.patch3.72 KBpericxc
#22 image_extension-2733615-22.patch3.45 KBmayurjadhav
#19 image_extension-2733615-1.patch3.45 KBpericxc
#13 image_extension-2733615.patch2.42 KBpericxc
#9 image_extension-2733615-8.patch819 bytesrajeshwari10
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pericxc created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Version: 8.1.x-dev » 8.2.x-dev
Priority: Normal » Minor

Out of curiosity: what are you missing?

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Allow entering file extensions when inline image uploading enabled » EditorImageDialog: allow the list of allowed file extensions to be configured
pericxc’s picture

pericxc CreditAttribution: pericxc commented

pdf and svg

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
  • PDF is not an image, you can't reference that in an <img> tag.
  • Embedding SVG is very very very dangerous. I recommend you search the internet for "SVG XSS".
pericxc’s picture

pericxc CreditAttribution: pericxc commented

still prefer to have an option to add a file extension.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

I understand. This is as low priority as it gets though:

  • few people need this
  • you haven't made a convincing case for either of the extensions you want to add

So, if you want to see this happen in the near future, you'll have to work on the patch that adds support for this. "Scratch your own itch" and all that :)

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Assigned: Unassigned » rajeshwari10
rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Status: Active » Needs review
FileSize
image_extension-2733615-8.patch819 bytes

I have added the extensions.

Thanks!!

Status: Needs review » Needs work

The last submitted patch, 9: image_extension-2733615-8.patch, failed testing.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented

Hi Wim Leers,

In the patch, I have added the extension-pdf and svg as per your discussion. But why it has failed,I am not able to get it.

Please can you review the patch and explain me.

Thanks!!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Active

In the patch, I have added the extension-pdf and svg as per your discussion.

That's not per our discussion. It's also not what this feature request is requesting.

Please re-read the issue, you misread it :)

pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615.patch2.42 KB

I would expected something like this.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commented
Assigned: rajeshwari10 » Unassigned
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Assigned: Unassigned » pericxc
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: image_extension-2733615.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

#13: yep. Next steps:

  1. update config schema (this will fix all test fails)
  2. test coverage
pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615-1.patch3.45 KB
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: image_extension-2733615-1.patch, failed testing.

mayurjadhav’s picture

mayurjadhav CreditAttribution: mayurjadhav commented
Status: Needs work » Needs review
FileSize
image_extension-2733615-22.patch3.45 KB

I just updated schema file label, let's try this patch for now, will work on this if patch fails to apply successfully.

Status: Needs review » Needs work

The last submitted patch, 22: image_extension-2733615-22.patch, failed testing.

pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615-2.patch3.72 KB
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 24: image_extension-2733615-2.patch, failed testing.

pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Needs work » Needs review
pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615-3.patch5.5 KB

Status: Needs review » Needs work

The last submitted patch, 28: image_extension-2733615-3.patch, failed testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Can you please provide interdiffs? https://www.drupal.org/documentation/git/interdiff

pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
interdiff-image_extension-2733615-1-4.txt1.56 KB

interdiff for patch-4 and patch-1: interdiff-image_extension-2733615-1-4.txt

pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615-4.patch5.1 KB
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 32: image_extension-2733615-4.patch, failed testing.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Related issues: +#1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only)

related, #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only)

pericxc’s picture

pericxc CreditAttribution: pericxc commented
FileSize
image_extension-2733615-5.patch4.94 KB
pericxc’s picture

pericxc CreditAttribution: pericxc commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 36: image_extension-2733615-5.patch, failed testing.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Assigned: pericxc » pashupathi nath gajawada
Status: Needs work » Needs review
FileSize
2733615-39.patch4.98 KB

Please find the updated patch #39.

Status: Needs review » Needs work

The last submitted patch, 39: 2733615-39.patch, failed testing.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Closed (works as designed)
Related issues: +#3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11

We're not going to do this, because: #3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11.