Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Drush and Composer both install themes in themes/contrib if that directory exists, but basic-install fails if Basic is installed there.
It should look for 'themes/contrib/basic' if 'themes/basic' is not found and fail gracefully if neither exists.
Comment | File | Size | Author |
---|---|---|---|
#2 | look-for-basic-in-contrib-dir-2732451-2.patch | 789 bytes | beeyayjay |
Comments
Comment #2
beeyayjay CreditAttribution: beeyayjay commentedComment #3
joelpittetmaybe we could do
dirname(__DIR__)
? and then just remove theDRUPAL_ROOT
from that?Comment #4
ooystein CreditAttribution: ooystein at Ramsalt Lab commentedI solved this in the latest patch on this issue #2717331-7: Handle file copy error in drush basic-install on multisite.
You can get the path to basic from the theme it self,
$theme_handler->getTheme('basic')->getPath()
. I think this is a better solution as it does not restrict the theme from being placed outside of 'themes/contrib/basic' or 'themes/basic' as is the case if you place it in 'sites/*/themes/'.Comment #5
beeyayjay CreditAttribution: beeyayjay commentedThanks, ooystein. I agree, that's a better solution.
Since there's already a patch that deals with this, I'll go ahead and close this issue.