Having a makefile inside a module can potentially affects other people workflow's using makefiles.

See #1103872: Change name of ckeditor.make to ckeditor.make.example for drush make module and #2002264: Rename the .make.example file to .make.

Things like having the module on a directory other than sites/all/modules is not possible, other versions or patches cannot be added, etc.

CommentFileSizeAuthor
#2 botcha-rename_makefile-2002264-2.patch1.09 KBhanoii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hanoii created an issue. See original summary.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented
Status: Active » Needs work
FileSize
botcha-rename_makefile-2002264-2.patch1.09 KB

Attached is a patch that does what seems to be the best practice.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented
Status: Needs work » Needs review