Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.These Provision commits for hosting_le make it impossible to override the behavior for other Let's Encrypt solutions:
- http://cgit.drupalcode.org/provision/commit/?id=7bff65d2f2fbb970f172e3a0...
- http://cgit.drupalcode.org/provision/commit/?id=f6a1d2cd024d9cae6fa80dc0...
- http://cgit.drupalcode.org/provision/commit/?id=a1637851e34646b4edd3e905...
- http://cgit.drupalcode.org/provision/commit/?id=ccce1cadd54ce3c32a6781f4...
This limits what we can do in the long run, which should only be implemented in a contrib module.
I may have missed some commits, the point is we can't hardcode a path like this.










Comments
Comment #2
bgm CreditAttribution: bgm at Coop SymbioTIC commentedFor Nginx:
(or just remove the well-known block in provision/http/Provision/Config/Nginx/Inc/vhost_include.tpl.php)
Comment #3
omega8cc CreditAttribution: omega8cc commentedIt had to be hardcoded because we don't have proper frontend integration in
hosting_le, so it was not possible to make the path configurable.This can be solved via proper implementation, like hosting_certificate
Once it is configurable (either in
hosting_certificateand/or inhosting_le), we can safely replace the hardcoded paths with something liked('@server_master')->http_le_path, etc.It is not set in stone, after all, and it was a quick shot to make the first integration option working.
Comment #4
ergonlogicThe path to the 'well-known' directory doesn't have to be configurable from the front-end, nor generally should it be. But it shouldn't be hard-coded into the vhost templates either. hosting_le should just implement
drush_hook_provision_nginx_vhost_config()anddrush_hook_provision_apache_vhost_config()to write these configs into the vhosts.Comment #5
ergonlogicAnother issue with this implementation is that the directory containing the challenges won't get sync'd to remote servers, thus limiting use of Letsencrypt to single-server deployments.
Comment #6
omega8cc CreditAttribution: omega8cc commentedGood points! Removed. We can add this with hooks.
Comment #7
omega8cc CreditAttribution: omega8cc commentedMoving to the correct queue.
Comment #8
omega8cc CreditAttribution: omega8cc commentedRelated commit.
Comment #9
omega8cc CreditAttribution: omega8cc commentedWe have implemented this in hosting_le, as suggested.