Problem/Motivation

I wrote some custom processor plugins which depends on WidgetOrderPluginBase a while ago. https://www.drupal.org/commitlog/commit/70809/09ee8c651dcfa41affd17aae88... call to sortResults. The arguments of sortResults does not match the WidgetOrderProcessorInterface.

Proposed resolution

I saw the new SortProcessorInterface. Is WidgetOrderPluginBase deprecated in favour of it?

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 2731347-6.patch2.13 KBborisson_
#6 interdiff.txt1.36 KBborisson_
#2 2731347-2.patch788 bytesborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Active » Needs review
FileSize
2731347-2.patch788 bytes

Yes, the old interface was changed and is removed. We need to change that to fix #2656668: Facet's results sorting with multiple sorts..

Status: Needs review » Needs work

The last submitted patch, 2: 2731347-2.patch, failed testing.

The last submitted patch, 2: 2731347-2.patch, failed testing.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented

Looks like we should remove the SortProcessorInterface altogether?. Hmm no, makes no sense.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.36 KB
2731347-6.patch2.13 KB

Yeah, that makes more sense.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs review » Fixed

As far as I can see, nothing really uses the ::sort method any more. So I think we can remove this. The tests also seem to pass still and I think that should prove that this patch is ok. Committed this. Thanks @webflo!

  • borisson_ committed 1146553 on 8.x-1.x 
    Issue #2731347 by borisson_: WidgetOrderPluginBase::sort does not match...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.