The module has minimal tests in Drupal 7, those should be ported to Drupal 8. The test supporting module is already ported (#2730809: Update l10n_client test module to Drupal 8 to prepare for testing) but may need to be adjusted for its use of state too. But the test is not ported yet. It should be simple to do, given it is a small test with form testing only. I would test the l10n_client_contributor via the built-in UI only for a start (that is the only UI that should already actually work).

CommentFileSizeAuthor
#12 port-test-2730919-l10n_client-11.patch11.32 KBsegi
#9 port-test-2730919-l10n_client.patch11.33 KBsegi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

segi’s picture

segi CreditAttribution: segi at Cheppers commented
Assigned: Unassigned » segi
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

@segi: yay, are you planning to post an in-progress patch? :)

segi’s picture

segi CreditAttribution: segi at Cheppers commented

I'm planning to post a working test. :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

#2775817: The module install working properly only with standard install profile now landed. Anything else blocking this? Thanks!

segi’s picture

segi CreditAttribution: segi at Cheppers commented
Issue tags: +#drupalaton
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -#drupalaton +Drupalaton

Fix tag.

segi’s picture

segi CreditAttribution: segi at Cheppers commented

Just an update, I started to work on it again. I'm close to finish it.

segi’s picture

segi CreditAttribution: segi at Cheppers commented
FileSize
port-test-2730919-l10n_client.patch11.33 KB

Here is the first version, I did a little more changes as just the test because in the current status of the module not testable, so I split up the submit function for more pieces. I think we have to concentrate for this issue https://www.drupal.org/node/2575401. This will change the test in the patch and maybe we will extend it in the future.

segi’s picture

segi CreditAttribution: segi at Cheppers commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: port-test-2730919-l10n_client.patch, failed testing.

segi’s picture

segi CreditAttribution: segi at Cheppers commented
FileSize
port-test-2730919-l10n_client-11.patch11.32 KB

Awww, ok I fixed it.

segi’s picture

segi CreditAttribution: segi at Cheppers commented
Status: Needs work » Needs review
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Fixed

Superb. Reviewed this in person, talked to @segi. We do need to fix #2575401: Localization UI submodule does not work with Drupal 8/9 yet first to be able to test that. That would need to be expanded with the Needs tests tag then :)

  • Gábor Hojtsy committed 9bf8d59 on 8.x-1.x 
    Issue #2730919 by segi: Port tests to Drupal 8 — skip form UI testing...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +SprintWeekend2017

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.