FILE: d8/modules/contrib/entity_print/entity_print.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
38 | WARNING | Unused variable $plugin_id.
----------------------------------------------------------------------

FILE: d8/modules/contrib/entity_print/entity_print.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
36 | WARNING | Unused variable $entity_type.
37 | WARNING | Unused variable $bundle.
----------------------------------------------------------------------

FILE: ...les/entity_print_commerce_order/entity_print_commerce_order.info
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | No PHP code was found in this file and short open tags
| | are not allowed by this install of PHP. This file may
| | be using short open tags but PHP does not allow them.
----------------------------------------------------------------------

FILE: ...es/contrib/entity_print/src/Controller/EntityPrintController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
93 | WARNING | Unused bound variable $entity_type.
93 | WARNING | Unused bound variable $entity_type.
93 | WARNING | Unused bound variable $entity_id.
93 | WARNING | Unused bound variable $entity_id.
95 | WARNING | Variable $this is undefined.
----------------------------------------------------------------------

FILE: d8/modules/contrib/entity_print/src/Form/SettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
127 | WARNING | #description values usually have to run through t()
| | for translation
----------------------------------------------------------------------

FILE: ...8/modules/contrib/entity_print/src/Plugin/Action/PdfDownload.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
115 | WARNING | Variable $this is undefined.
115 | WARNING | Variable $this is undefined.
124 | WARNING | Variable $this is undefined.
124 | WARNING | Variable $this is undefined.
----------------------------------------------------------------------

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jordanpagewhite created an issue. See original summary.

jordanpagewhite’s picture

Status: Active » Needs review
FileSize
2.61 KB

I'm pretty sure that this clears up the issues that are actually issues. Some of the issues reported by the CodeSniffer were non-issues. Let me know what you think.

benjy’s picture

FileSize
2 KB
4.01 KB

Just changed a few t() calls to $this->t()

benjy’s picture

Assigned: jordanpagewhite » Unassigned
Status: Needs review » Fixed

Committed, thanks.

  • benjy committed 17ee3a4 on 8.x-1.x authored by jordanpagewhite
    Issue #2730397 by benjy, jordanpagewhite: Clean up DrupalPractice issues...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.