FILE: d8/modules/contrib/entity_print/entity_print.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
38 | WARNING | Unused variable $plugin_id.
----------------------------------------------------------------------
FILE: d8/modules/contrib/entity_print/entity_print.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
36 | WARNING | Unused variable $entity_type.
37 | WARNING | Unused variable $bundle.
----------------------------------------------------------------------
FILE: ...les/entity_print_commerce_order/entity_print_commerce_order.info
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | No PHP code was found in this file and short open tags
| | are not allowed by this install of PHP. This file may
| | be using short open tags but PHP does not allow them.
----------------------------------------------------------------------
FILE: ...es/contrib/entity_print/src/Controller/EntityPrintController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
93 | WARNING | Unused bound variable $entity_type.
93 | WARNING | Unused bound variable $entity_type.
93 | WARNING | Unused bound variable $entity_id.
93 | WARNING | Unused bound variable $entity_id.
95 | WARNING | Variable $this is undefined.
----------------------------------------------------------------------
FILE: d8/modules/contrib/entity_print/src/Form/SettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
127 | WARNING | #description values usually have to run through t()
| | for translation
----------------------------------------------------------------------
FILE: ...8/modules/contrib/entity_print/src/Plugin/Action/PdfDownload.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
115 | WARNING | Variable $this is undefined.
115 | WARNING | Variable $this is undefined.
124 | WARNING | Variable $this is undefined.
124 | WARNING | Variable $this is undefined.
----------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#3 | 2730397-3.patch | 4.01 KB | benjy |
#3 | interdiff.txt | 2 KB | benjy |
#2 | 2730397-2.patch | 2.61 KB | jordanpagewhite |
Comments
Comment #2
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedI'm pretty sure that this clears up the issues that are actually issues. Some of the issues reported by the CodeSniffer were non-issues. Let me know what you think.
Comment #3
benjy CreditAttribution: benjy at PreviousNext commentedJust changed a few t() calls to $this->t()
Comment #4
benjy CreditAttribution: benjy at PreviousNext commentedCommitted, thanks.