Currently, when you create a video media entity or embed one in the WYSIWYG editor, it renders at an enormous size because it is a responsive video and therefore constrained only by the size of its container. By default, videos should always appear at a more manageable size.

CommentFileSizeAuthor
#7 2765525-30-8.2.x.patch10.72 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Status: Active » Postponed
balsama’s picture

Status: Postponed » Active
phenaproxima’s picture

I suggest this as a Lightning 8.x-1.01 target.

phenaproxima’s picture

Status: Active » Postponed

This is blocked, at the moment, by #2765525: Add AJAX command to add style sheets to CKEditor instances. When that is committed, we can attack this.

balsama’s picture

Status: Postponed » Active

Unblocked, and - I think - fixed elsewhere. @phenaproxima can you confirm/link/close?

phenaproxima’s picture

FileSize
10.72 KB

We'll need an 8.2.x version of #2765525: Add AJAX command to add style sheets to CKEditor instances to get this done. And here it is!

phenaproxima’s picture

Status: Active » Needs review

So I have made a branch on GitHub, 8.x-video-sizing, that opens the door to solving this forever. When Embed is returning a preview response, Lightning will apply any incoming CSS to the CKEditor instance, as well as the main window. Therefore, if a module or theme wants to make all responsive videos 50% of the CKEditor's width, they can attach CSS to do that. Before, they could attach the CSS but it would only be applied to the main window and have no effect in an iframe CKEditor instance.

Okay, so this doesn't directly solve the question of video sizing, and that is OK -- I think we'd prefer Lightning not to have an opinion about user-facing presentational things of that kind. But it most definitely solidly patches this functionality hole in core!

balsama’s picture

Status: Needs review » Reviewed & tested by the community

balsama’s picture

Status: Reviewed & tested by the community » Fixed
phenaproxima’s picture

Status: Fixed » Closed (fixed)