Missing bundle property on entity, if user has no access to the entity. [#2729253]

When user has no access to the taxonomy term, we get an error in og_get_user_roles() function:

EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in entity_extract_ids() (line 7880 of /var/www/horizon/includes/common.inc).

OG relies on entity_load_single succeeding when it is not guaranteed to do so.

Comment	File	Size	Author
#2	og-missing_bundle_property-2729253-2.patch	460 bytes	alan-ps
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 85 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 May 2016 at 12:55

alan-ps created an issue. See original summary.

Comment #2

alan-ps CreditAttribution: alan-ps commented 19 May 2016 at 13:08

Status:

Active

» Needs review

File	Size
og-missing_bundle_property-2729253-2.patch	460 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 85 pass

Should the user have roles in a group he doesn't have access to? To my mind - no, and we can fix it by adding a simple check. I've attached a patch for review.

Comment #3

mxr576

Hungarian

Hungary

CreditAttribution: mxr576 at Pronovix commented 13 December 2016 at 09:10

Comment #4

mxr576

Hungarian

Hungary

CreditAttribution: mxr576 at Pronovix commented 13 December 2016 at 09:11

Status:

Needs review

» Reviewed & tested by the community

Comment #5

mxr576

Hungarian

Hungary

CreditAttribution: mxr576 at Pronovix commented 13 December 2016 at 09:13

@alan-ps I think you should create a pull request on Github, because OG's development is happening there.

I've created an issue for this on Github as well: https://github.com/Gizra/og/issues/224

Comment #6

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 13 December 2016 at 18:12

+++ b/og.module
@@ -2765,7 +2765,10 @@ function og_get_user_roles($group_type, $gid, $uid = NULL, $include = TRUE, $che
+  if (!$group = entity_load_single($group_type, $gid)) {

As an API function I don't think it needs to check for the correctness of the data we pass it.

One might argue, that instead of return, we should actually throw an Exception.

Comment #7

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 13 December 2016 at 18:14

Status:

Reviewed & tested by the community

» Closed (won't fix)

I'll won't fix it. If you feel strongly differently, please re-open with an explanation why.

Comment #8

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Atelier7 commented 11 February 2020 at 13:33

Status:

Closed (won't fix)

» Needs review

EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in entity_extract_ids() (line 7880 of /var/www/horizon/includes/common.inc).

That is the exception.

The reason we are getting this is because certain user belongs to groups that no longer exists.

I think this is a valid patch