The PasswordConstraintInterface file has an incorrect return type on the validate method. It currently has a boolean return type, but should be PasswordPolicyValidation as the return type, as all the validation plugins currently are returning a PasswordPolicyValidation object.

CommentFileSizeAuthor
#2 interface-incorrect-return-type-2728753-2.patch568 bytesmroycroft
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mroycroft created an issue. See original summary.

mroycroft’s picture

mroycroft CreditAttribution: mroycroft at Workday, Inc. commented
FileSize
interface-incorrect-return-type-2728753-2.patch568 bytes

Here's a patch with the proposed fix.

mroycroft’s picture

mroycroft CreditAttribution: mroycroft at Workday, Inc. commented
Status: Active » Needs review
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein at CivicActions commented
Assigned: Unassigned » nerdstein

Reviewed, this patch looks good. Thank you.

I will be committing this weekend.

mahalingam_cs’s picture

mahalingam_cs CreditAttribution: mahalingam_cs at TATA Consultancy Services commented
Status: Needs review » Reviewed & tested by the community

Applied the patch successfully.Tested and verified.

  • nerdstein committed 9de196d on 8.x-3.x authored by mroycroft 
    Issue #2728753 by mroycroft: PasswordConstraintInterface has a method...
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein at CivicActions commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.