Problem/Motivation

Drupal.orgs Composer Endpoints und Drupal-Packagist uses different version schema. Pathauto uses the Drupal-Packagist version scheme in its composer.json, this does not work with Drupal.org

Proposed resolution

Move the version constraints to the info.yml. Let both implementations handle it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2727559-7.patch487 byteswebflo
#3 2727559-1.patch803 byteswebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Active » Needs review
FileSize
2727559-1.patch803 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Having them in the .info file breaks git checkouts, which is pretty annoying when developing.

I'd consider to just remove them, both alphas are out there for a long time now.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented

I think the git checkout issue has to be solved with either https://www.drupal.org/project/composer_deploy or https://www.drupal.org/project/git_deploy since version constraints are definitely going to be a thing when contrib modules start relying on semver constraints to ensure compatibility in their info files.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Agreed, but I don't think we need to add the necessary complexity here. We're talking about alpha versions, depending on other alpha versions, both of them came out month ago. It was useful when we had the new dependencies, to enforce users to update, but until we have some new dependency, I think we can remove them for now.

Also, my usual workaround for this is to just add the dependencies for tagged releases and then reverting it again. Then it works fine for everyone using the release, those that use -dev/git will have to figure this out themself.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs work » Needs review
FileSize
2727559-7.patch487 bytes

Fine for me.

  • Berdir committed a49a424 on 8.x-1.x authored by webflo 
    Issue #2727559 by webflo: Make pathauto compatible with Drupal Packagist...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.