Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grahl created an issue. See original summary.

grahl’s picture

Status: Active » Needs review
FileSize
780 bytes

The attached patch removes unshifting the submit handler which is empty (at least for me on 8.0.6).

I presume the original comment wanted to indicate the ordering for ldap_help's sake, or other modules which should have run after setting those base parameters. Unless there are other modules which inject here as well and for which ordering could then differ (though I can't imagine how) this should be safe.

larowlan’s picture

Status: Needs review » Fixed

Thanks!

  • larowlan committed a8d70b5 on 8.x-3.x
    Issue #2726675 by grahl, larowlan: Error on ldap_server.settings form
    

Status: Fixed » Needs work

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

The last submitted patch, 3: 2726537.cleanup.patch, failed testing.

larowlan’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.