Problem/Motivation

Let's put core/phpcs.xml and core/phpunit.xml into the example.gitignore

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 add-phpcs-phpunit-gitignore-example-2725541-1.patch303 bytesgargsuchi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi as a volunteer and at Acquia commented
FileSize
add-phpcs-phpunit-gitignore-example-2725541-1.patch303 bytes

Please finad attached a patch for the same.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Active » Reviewed & tested by the community

Seems reasonable for me!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 53fc35b and pushed to 8.1.x and 8.2.x as the example file is documentation and not API. Thanks!

  • alexpott committed 7947f6b on 8.2.x 
    Issue #2725541 by gargsuchi: Add phpcs.xml and phpunit.xml into the...

  • alexpott committed 53fc35b on 8.1.x 
    Issue #2725541 by gargsuchi: Add phpcs.xml and phpunit.xml into the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.