WI: UX prototypes for Trash module

https://www.drupal.org/project/trash could be considered the initial prototype for this :)

Which entity types do we have in core?

#1 and #2 don't feel strictly related to trash module, they're something we'll need to figure out earlier if core entity types get revision-enabled - could that be split out?

Certainly! Created two stub issues for those.

I am working on UX prototypes for Trash module.

Few goals:

1) Undo - add ability to undo “Move to trash” action

2) Single list of trashed items - currently every entity type has it’s own separate list of trashed items

3) Unifying when to show confirmation page
- When deleting content from /admin/content using checkboxes - user is redirected to the confirmation screen “Are you sure you want to delete these items?” When selecting “Delete” option from the “Operations” column on the same page or clicking on “Delete” on the node page itself moves content to trash directly

4) Wording: “Delete” vs “Move to trash” vs “Purge”
- “Delete” is used in the tab on node/edit and as an option under the “Operations” column on the /admin/content
- “Move to trash” is used in the confirmation message after deleting an item
- “Purge” is used in context of removing deleted item from the Trash. My feeling is that “Purge” may sound too technical to general user
- Proposal is to use Move to trash” & “Empty trash”

5) Settings page for trash
- set if the trash should be automatically emptied after some time
- set the number of days after which the trash will be emptied
- default content moderation state after moving items to trash
- default content moderation stat after restoring items
- set if you want to configure this for each entity type
^ if the last is set to yes - all of these settings could be overridden on the content moderation settings page per entity type

I will be adding wireframes/mockups here

My proposal re 1) Undo is to place the Undo link into the notification message that displays after item is moved to trash. This is the same approach as is used on Gmail, Amazon, in Google Material guidelines to name few examples

Here is a mockup for 2) Single list of trashed items

My proposal is to mimic admin/content page with few changes
- remove unnecessary filters
- replace columns and change their order to what makes more sense for trash

Note: this mockup is showing what the ultimate goal will be, probably not how it will be in the beginning.

re 3) Unifying when to show confirmation page

Motivation for confirmation page is to inform user that there is no point of return. Since we are adding the "Undo" functionality as a layer of "security" that user can recover data I am proposing to:
- drop the confirmation page when moving items to trash
- show confirmation page when user is restoring items from trash and emptying trash

re 4) Wording: “Delete” vs “Move to trash” vs “Purge”

My proposal is to use "Move to trash” & “Empty trash” to be consistent. This would mean that when Trash module is enabled all instances of "Delete" (for example on node/edit, node, or admin/content) should read "Move to trash".

After our discussion on the weekly UX call I've updated the trash list so that name is in the first column

re 3) Unifying when to show confirmation page

Also on the UX call, we agreed on this scenarios:
- show the confirmation page when user is emptying trash (destructive action)
- drop it when moving items to trash and restoring items from trash

1) undo - done, but needs #2800737: Add TrashManager::undo to revert to previous revision to improve it as it currently goes to the restore confirmation form.
2) done, but not with the polish of the screenshot in #19.
3) opened #2806517: Override /admin/content/node/delete to move entities to trash for this.
4) changed delete tab to "move to trash", the rest is still todo.
5) waiting on #2799785: Entity types with non-config bundles can not be moderated

This is looking great!

I am not totally sure we need to follow Mac's pattern of "Move to trash" but also not worried if we chose to go down that path. To me Delete signifies the same, if you have a trash function.

re #22 the reason for "Move to trash" is to show difference when you have the Trash module enable. With Trash disabled it would say Delete (destructive action), with Trash enabled it should say "Move to trash" (restorable)

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

Since this hasn't been touched in 6 years tagging for IS for remaining tasks (if any) for D10