We reviewed some of the open issues regarding skins, and how the current custom skin functionality works. It's clear that the custom skin feature in 7.x-2.x is not functional for JW Player 7.

Attached is a patch for review. There are also some other components we'll need to add into the Refactor theming patch to get this to work correctly. Thanks.

CommentFileSizeAuthor
#7 fix_custom_skin-2725089-7.patch6.54 KBjohnchque
#4 jw_player-fix_custom_skin-2725089-4.patch5.47 KBron_s
jw_player-fix_custom_skin-1.patch5.42 KBron_s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ron_s created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Patch is somehow broken:

patching file README.txt
patching file jw_player.module
Hunk #1 FAILED at 562 (different line endings).
patch: **** malformed patch at line 90: diff --git a/plugins/export_ui/jw_player_ctools_export_ui.inc b/plugins/export_ui/jw_player_ctools_export_ui.inc
ron_s’s picture

ron_s CreditAttribution: ron_s commented

Probably due to the recent commits. Line numbers start to get thrown off easily when changing different sections.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Status: Needs work » Needs review
FileSize
jw_player-fix_custom_skin-2725089-4.patch5.47 KB

Hmm, I'm guessing it is just due to line numbers. Here is a new version. There is nothing different between #1 and #4 except the git line indexing.

Let me know if this one works.

  • Berdir committed 6db7063 on 7.x-2.x authored by ron_s 
    Issue #2725089 by ron_s: Fix custom skin functionality for JW Player 7
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Now it applies, committed.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Patch (to be ported) » Needs review
FileSize
fix_custom_skin-2725089-7.patch6.54 KB

This should work. This also fixes when there are no skins. :)

  • Berdir committed 70fd665 on 8.x-1.x authored by yongt9412 
    Issue #2725089 by ron_s, yongt9412: Fix custom skin functionality for JW...
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs review » Fixed

This should be fixed right? :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.