The configuration options cannot be changed. Only the default option "Pre-populate the node form fields" is effective. Also, the toggle for publishing options is missing.

CommentFileSizeAuthor
#11 2724919-11.patch8.02 KBpwolanin
#11 increment-2724919-11.txt969 bytespwolanin
#10 2724919-8.patch7.88 KBpwolanin
#2 fix_set_data_on_admin_page-2724919-2.patch791 bytesmyLies
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wtchan created an issue. See original summary.

myLies’s picture

myLies CreditAttribution: myLies as a volunteer commented
FileSize
fix_set_data_on_admin_page-2724919-2.patch791 bytes

Fix changing options in configuration page.
I hope this helps

myLies’s picture

myLies CreditAttribution: myLies as a volunteer commented
Status: Active » Needs review
Bcwald’s picture

Bcwald CreditAttribution: Bcwald commented

This patch works in terms of letting you select differnt options in the admin, however the options

"Confirmation mode when using the "Save as a new node then edit" method
" do not work.

It still uses the prepopulate method with no save.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Needs review » Needs work

I can confirm that Bcwald said. I can see a new option in the admin but it does not work.

Boobaa’s picture

Boobaa
he/him
CreditAttribution: Boobaa at Pronovix for BrightCove commented
Related issues: +#2712079: Warning: Invalid argument supplied for foreach()

The patch allows saving the configuration settings, but none of them are respected. Additionally, this is related to #2712079: Warning: Invalid argument supplied for foreach() .

drupalfan2’s picture

drupalfan2 CreditAttribution: drupalfan2 as a volunteer commented

Warning disappeared and config settings is possible after applying both related patches.

But the configuration settings is still ignored: is saved now but has no effect.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented

The prefix should "node_clone" - do we need to fix the form?

@drupalfan2 - yes, the other method is not yet implemented, so maybe need to hide it.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented

Actually - the config had a correct name space, so adding more prefix is not right $config = $this->config('node_clone.settings');

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented
FileSize
2724919-8.patch7.88 KB

Here's a partially working patch with more fixes, but not resetting the publishing options correctly yet.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and at SciShield commented
Status: Needs work » Needs review
FileSize
increment-2724919-11.txt969 bytes
2724919-11.patch8.02 KB

ok, small additional fix and code comment copied from the node type form.

mhavelant’s picture

mhavelant CreditAttribution: mhavelant at Brainsum for Tieto commented

#11 fixed it for me, thanks!