See #2359437: [meta] Remove entity_load* family of functions usage from the code base

CommentFileSizeAuthor
#10 remove_entity_load_block-2723583-10.patch3.57 KBmchampsee
#7 remove_entity_load_block-2723583-6.patch3.39 KBmchampsee
#3 remove_entity_load_block-2723583-3.patch2.27 KBmchampsee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

valthebald created an issue. See original summary.

mchampsee’s picture

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC for UCSF Center for HIV Information commented
Assigned: Unassigned » mchampsee

Working on this at DC New Orleans sprint.

mchampsee’s picture

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented
FileSize
remove_entity_load_block-2723583-3.patch2.27 KB

Patch Attached. Removed references to entity_load and replaced them.

mchampsee’s picture

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented
Assigned: mchampsee » Unassigned
Status: Active » Needs review

changed status

Status: Needs review » Needs work

The last submitted patch, 3: remove_entity_load_block-2723583-3.patch, failed testing.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald as a volunteer commented 
entity_load_multiple_by_properties('block', ...)

should be replaced with

\Drupal::entityTypeManager()->getStorage('block')->loadByProperties(...)
mchampsee’s picture

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented
Status: Needs work » Needs review
FileSize
remove_entity_load_block-2723583-6.patch3.39 KB

Re-rolled to add namespace and included changing references in the block_content module.

Status: Needs review » Needs work

The last submitted patch, 7: remove_entity_load_block-2723583-6.patch, failed testing.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald as a volunteer commented

@mchampee: please check my comment #6

mchampsee’s picture

mchampsee CreditAttribution: mchampsee at Champsee Solutions, LLC commented
FileSize
remove_entity_load_block-2723583-10.patch3.57 KB

here you go...

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald as a volunteer commented
Status: Needs work » Needs review

Let's test that

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The patch in #10 applies. My IDE says it successfully changes all occurrences of entity_load*'block'. The patch stays in scope and looks right.

Therefore woot, RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: remove_entity_load_block-2723583-10.patch, failed testing.

The last submitted patch, 10: remove_entity_load_block-2723583-10.patch, failed testing.

marvin_B8’s picture

marvin_B8 CreditAttribution: marvin_B8 as a volunteer and at comm-press commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 9aa63fd and pushed to 8.2.x. Thanks!

  • catch committed 9aa63fd on 8.2.x 
    Issue #2723583 by mchampsee, valthebald: Remove entity_load* usage for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.