The field for the facet URL name says ' A unique machine-readable name. Can only contain lowercase letters, numbers, and underscores. '

Is there a reason this can't have hyphens, since other Drupal URLs and Views filter query parameter can contain them?

CommentFileSizeAuthor
#11 allow_hyphens_in_facet-2723365-11.patch3.01 KBStryKaizer
#11 interdiff.txt647 bytesStryKaizer
#5 allow_hyphens_in_facet-2723365-5.patch3.01 KBborisson_
#5 interdiff.txt1.38 KBborisson_
#4 allow_hyphens_in_facet-2723365-3.patch1.62 KBStryKaizer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented

Oh no, that makes sense.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and commented
Status: Active » Needs review

I used the same pattern as views uses for exposed filters now (Only letters, digits and the dot ("."), hyphen ("-"), underscore ("_"), and tilde ("~")),

Tests will prolly be red, still need to fix tests and maybe add some more coverage to ensure the new characters work fine.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and commented
FileSize
allow_hyphens_in_facet-2723365-3.patch1.62 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
FileSize
interdiff.txt1.38 KB
allow_hyphens_in_facet-2723365-5.patch3.01 KB

I added a test, this test proves that ^ is allowed in the url, I don't think that's right?

Status: Needs review » Needs work

The last submitted patch, 5: allow_hyphens_in_facet-2723365-5.patch, failed testing.

The last submitted patch, 5: allow_hyphens_in_facet-2723365-5.patch, failed testing.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and commented

Prolly not, looks like you found a bug in views ;)
c/p regex from views

Lets create an issue for this in views, and follow their implementation, as exposed filters' Filter identifier is almost the same as our url_alias

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and commented
Related issues: +#2731333: Filter identifier in exposed filters allow more characters than description states
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented

I posted a patch to #2731333: Filter identifier in exposed filters allow more characters than description states. The core views exposed filter identifier was only tested with a space, and there was a typo in the regex.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and commented
Status: Needs work » Needs review
FileSize
interdiff.txt647 bytes
allow_hyphens_in_facet-2723365-11.patch3.01 KB

Updated regex with changes from #2731333: Filter identifier in exposed filters allow more characters than description states

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs review » Fixed

Test agrees, thanks.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented

  • borisson_ committed ed77bcd on 8.x-1.x authored by StryKaizer 
    Issue #2723365 by StryKaizer, borisson_: allow hyphens in facet URLs?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.