We should be nice and remove module variables on uninstall.

Tasks

  • Create uninstall file
  • Add variable_del for each module's variable
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tunic created an issue. See original summary.

NitinSP’s picture

Assigned: Unassigned » NitinSP
NitinSP’s picture

Create new ga_push.install file and include the code to delete configuration variable after uninstalling this module. Please review and merge this changes.

NitinSP’s picture

Assigned: NitinSP » Unassigned
Status: Active » Needs review
GeduR’s picture

Status: Needs review » Needs work

Thanks NitinSP, the module doesn't use dynamic variables just 2 so we should just delete that ones (that way we not deleted other module variables by mistake).

  • GeduR committed b540612 on 7.x-1.x
    Issue #2723211 by NitinSP, GeduR: Remove module variables on uninstall
    
GeduR’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.