The Drupal.Commenting.FunctionComment.ReturnCommentIndentation error is currently not fixable. I think this should be fixable.

CommentFileSizeAuthor
#4 interdiff-2721917-2-4.txt1.23 KBanoopjohn
#4 coder-fix-ReturnCommentIndentation-2721917-4.patch3.21 KBanoopjohn
#2 coder-fix-ReturnCommentIndentation-2721917-2.patch1.54 KBanoopjohn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anoopjohn created an issue. See original summary.

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
Status: Active » Needs review
FileSize
coder-fix-ReturnCommentIndentation-2721917-2.patch1.54 KB

Please find attached a patch that attempts to make this error fixable. Please review and let me know if this is alright.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi as a volunteer commented
Status: Needs review » Needs work

Looks good, can you also add a test in FunctionCommentUnitTest.inc, so that we cover it there also?

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
FileSize
coder-fix-ReturnCommentIndentation-2721917-4.patch3.21 KB
interdiff-2721917-2-4.txt1.23 KB

Please find attached a patch that includes the tests.

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
Status: Needs work » Needs review

  • klausi committed 1f8b131 on 8.x-2.x authored by anoopjohn 
    Issue #2721917 by anoopjohn, klausi: Implemented fixer for @return...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi as a volunteer commented
Status: Needs review » Fixed

Thanks, added a couple more test cases and committed it.

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented

Great. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.