Remove email, sex, birth_date base fields from Individual

Original summary

Problem/Motivation

After we add new fields(email, sex, birth_date) to individual entity, make those fields configurable.

Proposed resolution

- Create custom settings form where you have a custom settings UI and then set the settings there based on that configuration.
- Update the contact view already here to show the email and also have a a filter for it.

CommentFileSizeAuthor
#12 crm_core-2721775-10-12-interdiff.txt1.4 KBRoSk0
#12 crm_core-2721775-12.patch10.46 KBRoSk0
#10 crm_core-2721775-8-10-interdiff.txt2.98 KBRoSk0
#10 crm_core-2721775-10.patch10.27 KBRoSk0
#8 crm_core-2721775-8.patch7.55 KBRoSk0
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

CTaPByK created an issue. See original summary.

CTaPByK’s picture

CTaPByK CreditAttribution: CTaPByK at MD Systems GmbH commented
Title: Make individual fields(email, sex, birth_date) configurable. » Make individual fields configurable.
Issue summary: View changes
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Not sure about this direction. I fear we will end up with a crazy amount of configurable items...

For instance, just because things are configurable won't help us adapt default views and other configurable items. Not sure what the real value is for these fields, it we would offer a known well prefixed field name that can be easily used / reused.

mikran’s picture

mikran CreditAttribution: mikran at Mediamaisteri Oy commented

I was a bit surprised to find out that these are base fields and not normal fields. If these were just normal fields, one could delete the field or hide it when it's not wanted. And yes, views would need to be updated after too but that's why these are just default fields / views and ones that site owner can update, right?

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Title: Make individual fields configurable. » Remove redundant base field from Individual
Assigned: Unassigned » RoSk0
Category: Feature request » Task
Issue summary: View changes
Related issues: +#2928466: Remove email_with_type field type from CRM Core

The only field which make sense for me as a base field is a name for Individual. Rest is redundant and shouldn't be bundled as part of core. There is many use cases when sex, date of birth or email doesn't play key roles in CRM system.

I'm going to wait some time for feedback from community and then I will remove sex, birth_date and email base fields.

Also created a task to remove email with type field from CRM Core, it doesn't belong to this project.

mikran’s picture

mikran CreditAttribution: mikran at Mediamaisteri Oy commented

I agree. Name is problematic base field too as name field does all of the configuration on storage level and not on field instance level which would be best for CRM.

Pancho’s picture

Pancho
Location UTC+2 🇪🇺 EU
CreditAttribution: Pancho as a volunteer commented

Agree with both of you, @RoSk0 and @mikran: all of these should be normal rather than base fields. While sex, birth date and email should be optional, the name field at least needs to be fully configurable.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Assigned: RoSk0 » Unassigned
Status: Active » Needs review
FileSize
crm_core-2721775-8.patch7.55 KB

Patch to remove sex, birth_date and email base fields.

Status: Needs review » Needs work

The last submitted patch, 8: crm_core-2721775-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Status: Needs work » Needs review
FileSize
crm_core-2721775-10.patch10.27 KB
crm_core-2721775-8-10-interdiff.txt2.98 KB

Fixed failing test and coding standards.

Status: Needs review » Needs work

The last submitted patch, 10: crm_core-2721775-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Status: Needs work » Needs review
FileSize
crm_core-2721775-12.patch10.46 KB
crm_core-2721775-10-12-interdiff.txt1.4 KB

Removed email test leftovers.

  • RoSk0 committed f0d5d80 on 8.x-1.x 
    Issue #2721775 by RoSk0: Remove redundant base field from Individual
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.