Follow-up to #2380293: Properly inject services into ModuleInstaller

Follow-up to #2324055: Split up the module manager into runtime information and extension information.

Problem/Motivation

#2380293: Properly inject services into ModuleInstaller double declares the arguments to the module installer in the service YAML breaking libyaml parsers.

Proposed resolution

Only declare once.

CommentFileSizeAuthor
#2 fix_double_argument-2721741-2.patch730 bytesneclimdul
module_installer_double_arguments.patch730 bytesneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul as a volunteer commented
FileSize
fix_double_argument-2721741-2.patch730 bytes

Same patch for testbot...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi as a volunteer commented
Status: Needs review » Reviewed & tested by the community

RTBC when testbot passes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 8df66f2 and pushed to 8.2.x. Thanks!

  • alexpott committed 8df66f2 on 8.2.x 
    Issue #2721741 by neclimdul: Fix double argument declaration in core....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.