The request must specify a site nid to clone [#2721373]

    // Set the ID of the site node to clone if it wasn't provided.
    if (empty($cloned_node_nid)) {
      if (empty($cloned_node_nid_saved = variable_get('hosting_saas_template_site_nid', ''))) {
        watchdog('hosting_saas', "Cannot populate site clone task: ID of site to clone was not specified. Either save it in the settings, or provide the site node ID as 'nid' in the POST form data.", array(), WATCHDOG_ERROR);
        return;
      }
      $cloned_node_nid = $cloned_node_nid_saved;
    }

The code implies we can leave out the nid, but it's a required argument of the task ressource:

Missing required argument nid

Since making the nid optional in the resources wouldn't make sense for almost any other use case, I think we should have a setting to override the provided nid with the Template site node ID (when using the hosting_saas user).

Alternatively, it might be better in the long run for hosting_saas to have its own resource (with no required parameters).

Comments

Comment #1

9 May 2016 at 01:28

gboudrias created an issue. See original summary.

Comment #2

colan

he/him

English

Toronto 🇨🇦

CreditAttribution: colan at Colan Schwartz Consulting commented 9 May 2016 at 15:14

It's optional because my use case doesn't always clone the same site. The template site will be provided with the client request. For example, in one call I'll want to clone foo.example.com, and another could be cloning bar.example.com.

If the template site isn't provided with the request, and it's not entered in the settings, then it will fail with an error. So either use case (always the same template or different templates) is acceptable.