The ParamCommentFullStop error should be automatically fixable. I will try to create a patch to allow this.

CommentFileSizeAuthor
#4 interdiff-2721239-2-4.txt2.15 KBanoopjohn
#4 coder-fix-paramcommentfullstop-2721239-4.patch1.84 KBanoopjohn
#2 coder-fix-paramcommentfullstop-2721239-2.patch3.58 KBanoopjohn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anoopjohn created an issue. See original summary.

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
Assigned: anoopjohn » Unassigned
Status: Active » Needs review
FileSize
coder-fix-paramcommentfullstop-2721239-2.patch3.58 KB

Please find a patch that does this. Please review and let me know if there are issues.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work 
+++ b/coder_sniffer/Drupal/Test/bad/BadUnitTest.php
--- a/coder_sniffer/Drupal/Test/bad/bad.php
+++ b/coder_sniffer/Drupal/Test/bad/bad.php

let's not modify bad.php. It it used for legacy purposes, but anything that should produce an error/warning should be put in the sniff specific unit test. In this case FunctionCommentUnitTest.inc

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
FileSize
coder-fix-paramcommentfullstop-2721239-4.patch1.84 KB
interdiff-2721239-2-4.txt2.15 KB

Thanks for the review and inputs. I have updated the patch.

I have also started a documentation page on how to contribute to coder.

https://www.drupal.org/node/2731617

It would be good to document this so that new contributors will be able to contribute to coder more easily without having to eat into the time of the maintainers (which I seem to be doing well now - thanks for all the patient guidance).

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented
Status: Needs work » Needs review

  • klausi committed 6572b55 on 8.x-2.x authored by anoopjohn 
    Issue #2721239 by anoopjohn: Implemented fixer to add a full stop after...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Fixed

Ran phpcbf --standard=PHPCS one more time on the sniff file and committed the result, thanks!

anoopjohn’s picture

anoopjohn CreditAttribution: anoopjohn at Zyxware Technologies commented

Great. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.