Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Lets improve the 7.x-1.x-dev branch using the Drupal Coding Standards (https://www.drupal.org/coding-standards).
Comment | File | Size | Author |
---|---|---|---|
#19 | 2720899-19.patch | 7.1 KB | jordanpagewhite |
#14 | 2720899-14.patch | 6.65 KB | jordanpagewhite |
#9 | 2720899-9.patch | 7.45 KB | jordanpagewhite |
#7 | 2720899-7.patch | 6.65 KB | jordanpagewhite |
#5 | 2720899-5.patch | 6.65 KB | jordanpagewhite |
Comments
Comment #2
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedPlease review these edits. Again, as I said in the description, I am just trying to use the Drupal Coding Standards on this 7.x-1.x-dev branch. Please let me know if you see anything that you are concerned with. I would be happy to make edits or improvements. Benjy, I assume you wrote tests/entity_print.test, so if you want to write a class doc comment. If there is nothing distinct that should go into that test class doc comment, maybe we should just use an {@inheritdoc}. Let me know.
Comment #4
benjy CreditAttribution: benjy at PreviousNext commentedThanks, happy to commit this once the patch applies cleanly.
The code provided*
Comment #5
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedThanks! I fixed that line.
Comment #7
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedHmm. Trying to figure out why the patch isn't applying cleanly.
Comment #9
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedI forgot to pull the latest commit (http://cgit.drupalcode.org/entity_print/commit/?id=ca3ace9).
Comment #10
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedComment #12
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedAll the tests are passing locally for me. I can't figure out why they're failing here. If anyone has a suggestion, let me know. Thanks.
Comment #13
benjy CreditAttribution: benjy at PreviousNext commentedThe link you posted was to a commit on the 8.x-1.x branch but this patch looks to be agains the 7.x-1.x branch? Are you creating your patch against the correct branch?
Comment #14
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedHaha. You are right. What a silly mistake. Well, I removed those two lines of tags.
Comment #15
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedComment #16
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedWait, isn't #2718427 (https://www.drupal.org/node/2718427) on the 7.x-1.x-dev branch?
Comment #18
benjy CreditAttribution: benjy at PreviousNext commentedYeah sorry, that is the 7.x branch, misread it from cgit. Still not sure why your patch isn't applying? You don't have a patched version or anything do you?
Comment #19
jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commentedOkay, I deleted my repo and pulled down the 7.x branch again to start from scratch. Hopefully this does this trick.
Comment #21
benjy CreditAttribution: benjy at PreviousNext commentedThanks, committed.
Changed this to object on commit.