According to core/composer.json the drupal/core package can be used to replace "drupal/core-file-cache" and "drupal/core-php-storage" but this is a lie because no such components exist.
We do have "drupal/core-fileCache" and "drupal/core-phpStorage"
Simply fix the replace section to stop the lie and to make drupal/core resolve any "drupal/core-fileCache" and "drupal/core-phpStorage" dependencies. Changing the component names at this point is a breaking change so let's leave that for another issue.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 2720811-10.patch | 935 bytes | eric_a |
| #3 | 2720811-3.patch | 809 bytes | eric_a |
Comments
Comment #2
eric_a commentedComment #3
eric_a commentedOne more mismatch: replace section has "drupal/core-php-storage" but we have "drupal/core-phpStorage".
Comment #4
eric_a commentedComment #5
eric_a commentedGiven the names used, it's probably a better idea to rename the components than changing the replace section.
Comment #6
eric_a commentedComment #7
eric_a commentedRenaming the components at this point would be a breaking change. Let's just fix a bug and do #3.
Comment #8
eric_a commentedComment #9
mile23Patch in #3 applies and makes the package names match.
I'd say that we should fix the package names before they're made available in the stubtree split though. Now's the time.
Comment #10
eric_a commentedHere's the alternative to #3.
Comment #11
mile23Thanks. RTBC for #10. Package names now match
replacefromcore/composer.json, and also match other hyphenated component names likedrupal/core-dependency-injection.If we prefer camelCase package names, then the patch in #3 is good.
Comment #12
fabianx commentedRTBC for #10, as inofficial FileCache subcomponent co-maintainer, I like file-cache much more than fileCache in the composer.json.
Not sure, but this might need a CR though.
Comment #14
fabianx commentedBack to RTBC, random test fail?
Comment #15
mile23#10 still applies and does the same stuff. RTBC +1. Silly testbot!
Comment #16
alexpottAnd these are the names already in core/composer.json replace section... nice.
Committed and pushed 30555f01388308b198dfed1903a34e63696a6e47 to 8.2.x and 1252b70 to 8.1.x. Thanks!