Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The module name on drupal.org is inline_responsive_images
, but all the code is using responsive_image_inline.info
. That leads to troubles using drush. What's the proper module name?
Proposed resolution
Fix the code or project name to follow a consistent naming.
Comment | File | Size | Author |
---|---|---|---|
#7 | inline_responsive_images-different_naming_between_project_and_code-2720305-5.patch | 36.92 KB | NitinSP |
Comments
Comment #2
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedComment #3
mitchalbert CreditAttribution: mitchalbert at Betawerk commentedI will look into this soon.
Tnx for the report Szeidler
Comment #4
NitinSP CreditAttribution: NitinSP at Clarion Technologies commentedComment #5
NitinSP CreditAttribution: NitinSP at Clarion Technologies commented@mitchalbert
I have rename the file to "inline_responsive_images" as well as rename "responsive_image_inline" to "inline_responsive_images" and create a patch but it show error.
I am trying to separate patch got insert new file and delete existing one but this also not working.
Can you guide me what strategy we need to follow to resolve this issue.
Comment #6
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedWhat shows the error? Drupal after applying the patch or something happened during the patch creation?
In the first case, you would need to uninstall the module with the old name first and then installing the module with the fixed name after applying changes. Then it should work like charm. I also did it that way in my environments.
Comment #7
NitinSP CreditAttribution: NitinSP at Clarion Technologies commented@szeidler
I go through following steps
1. Rename all files with name inline_responsive_images
2. Also rename all function with inline_responsive_images
3. After that test this module in my local and its working fine
4. After testing create patch file of that file.
5.But when I am trying to apply this patch it show following error
error: patch failed: responsive_image_inline.info.yml:1
error: responsive_image_inline.info.yml: patch does not apply
error: patch failed: responsive_image_inline.module:1
error: responsive_image_inline.module: patch does not apply
error: patch failed: src/Form/ResponsiveEditorImageDialog.php:25
error: src/Form/ResponsiveEditorImageDialog.php: patch does not apply
error: patch failed: src/Plugin/Filter/FilterImageStyle.php:43
error: src/Plugin/Filter/FilterImageStyle.php: patch does not apply
error: patch failed: src/Plugin/Filter/FilterResponsiveImageStyle.php:39
error: src/Plugin/Filter/FilterResponsiveImageStyle.php: patch does not apply
Please check attached patch file also
Comment #8
mitchalbert CreditAttribution: mitchalbert at Betawerk commentedComment #10
mitchalbert CreditAttribution: mitchalbert at Betawerk commentedI fixed this issue. Please uninstall and reinstall the module. If you dont do this, errors will occur
uninstalling will also remove your text format settings. So you need to reconfigure it.
Comment #12
fkelly12054@gmail.com CreditAttribution: fkelly12054@gmail.com as a volunteer commentedUpdated to 8.x-2.0 a couple of days ago. Despite numerous attempts at uninstalling and reinstalling the module (and consequently reconfiguring ckeditor) I keep coming up with some variant of this error message. I have looked all over my system for any remaining artifact of "responsive_image_inline", cleared cache, even truncated all cache tables. Deleted 8.x.2.0 from my file system. I've had cpanel do a regex search for any old occurrence of responsive_image_inline, no luck. Looks to me like bootstrap reads in all the yml files it can find so if there was some artifact of the misnamed responsive_image_inline lying around it could cause the problem but I'm not seeing where it could be.
example 1.
Location http://fkelly.org/drupal8/admin/config
Referrer http://fkelly.org/drupal8/admin/reports/dblog
Message User warning: The following module is missing from the file system: responsive_image_inline in drupal_get_filename() (line 233 of /home/fkelly5/public_html/drupal8/core/includes/bootstrap.inc).
example 2.
Location http://fkelly.org/drupal8/admin/config
Referrer http://fkelly.org/drupal8/admin/config/content/formats/manage/full_html
Message User warning: The following module is missing from the file system: responsive_image_inline in drupal_get_filename() (line 233 of /home/fkelly5/public_html/drupal8/core/includes/bootstrap.inc).
There also appears to be a PHP warning message:
Notice: Undefined variable: image_options_keys in inline_responsive_images_form_editor_image_dialog_alter() (line 63 of /home/fkelly5/public_html/drupal8/modules/inline_responsive_images/inline_responsive_images.module).
I previously suggested that line 63 be:
'#default_value' => isset($image_element['data-image-style']) ? $image_element['data-image-style'] : key($image_options),
which let's the first style appear in the select box rather than "select".
Comment #13
mitchalbert CreditAttribution: mitchalbert at Betawerk commentedI also had this issue.
I don't know the right way to fix it...
What i did....get a previous version of the module(with the old name) and uninstall that one before installing the newer version. This is how i fixed it on my sites.
Comment #14
fkelly12054@gmail.com CreditAttribution: fkelly12054@gmail.com as a volunteer commentedWell, I know that things don't happen by accident. And I don't have a full development system here or devel installed or the tools to trace execution as it happens. Clearly something in bootstrap.inc or a function that bootstrap calls is causing this problem.
I backed up my system (home directory) from a web host and used my IDE (Nusphere) to globally search for "responsive_image_inline" Curses, not found.
So, I used PHPmyadmin to dump the database to a text (sql) file then downloaded and searched that. Sure enough there is a table named "key_value" and that has a record in it:
('system.schema', 'responsive_image_inline', 0x693a383030303b), where
'system.schema' is the field named "collection" , 'responsive_image_inline' is the field named "name" and there is a hex value: "0x693a383030303b" stored in a blob field named "value".
I'm going to delete this record now and see if the error goes away.
Seems like the system schema should be updated, deleting the responsive_image_inline record when the module is uninstalled. I'll report back status when I see if the problem goes away. If it works it could be a work around to what is, in any event, an isolated problem.
Comment #15
fkelly12054@gmail.com CreditAttribution: fkelly12054@gmail.com as a volunteer commentedDeleting the responsive_image-inline record from the key_value table seems to have resolved the missing module error message on my site. Anyone else trapped in the same "hole" might try that.